Skip to content

fix(challenge-listing): sorting by dates & phase displaying #4771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

cagdas001
Copy link
Collaborator

  • Add phaseStartDate and phaseEndDate helper functions at challenge-detail/helper
    to get the correct start/end date of a phase.
  • TIME_TO_REGISTER, TIME_TO_SUBMIT and MOST_RECENT sorting functions updated to reflect above change.
  • ProgressBarTooltip and ChallengeCard/Status updated to display correct phase start/end dates.

Addresses #4715, #4716

* Add `phaseStartDate` and `phaseEndDate` helper functions at `challenge-detail/helper`
to get the correct start/end date of a phase.
* `TIME_TO_REGISTER`, `TIME_TO_SUBMIT` and `MOST_RECENT` sorting functions updated to reflect above change.
* `ProgressBarTooltip` and `ChallengeCard/Status` updated to display correct phase start/end dates.

Addresses topcoder-platform#4715, topcoder-platform#4716
@sushilshinde
Copy link
Collaborator

@cagdas001 test failed, please fix

@cagdas001
Copy link
Collaborator Author

@cagdas001 test failed, please fix

@sushilshinde fixed

@sushilshinde sushilshinde merged commit b041baa into topcoder-platform:integration-v5-challenge-api Aug 21, 2020
sushilshinde added a commit that referenced this pull request Aug 28, 2020
fix(challenge-listing): sorting by dates & phase displaying
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants