Skip to content

[$50]Past contests : sort by most recent does not work as expected #4716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SathyaJayabal opened this issue Aug 6, 2020 · 10 comments
Closed

[$50]Past contests : sort by most recent does not work as expected #4716

SathyaJayabal opened this issue Aug 6, 2020 · 10 comments
Assignees
@cagdas001
Labels
Challenge Listing P3 Normal (resolved within 7 days) Prod Env Environment QA Pass tcx_Assigned tcx_FixAccepted tcx_Paid v5-intgration-sub-code
Milestone
v1.1.1

Comments

@SathyaJayabal
Copy link
Collaborator

topcoder-platform/challenge-api#260
@SathyaJayabal SathyaJayabal added Challenge Listing P2 Important (resolve within 3 days) Beta Env Environment v5-intgration-sub-code labels Aug 6, 2020
@sushilshinde sushilshinde changed the title Past contests : sort by most recent does not work as expected [$50]Past contests : sort by most recent does not work as expected Aug 10, 2020
@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30136487 has been created for this ticket.

This is an automated message for crazyk via Topcoder X

@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30136487 has been updated - it has been assigned to cagdas001.

This is an automated message for crazyk via Topcoder X

cagdas001 added a commit to cagdas001/community-app that referenced this issue Aug 11, 2020
@cagdas001
fix(challenge-listing): sorting functions
490c00b 
Fix for MOST_RECENT, TIME_TO_REGISTER and TIME_TO_SUBMIT sortings.
  * Since the V5 API  returns inconistent values for
    (`registrationStartDate`, `registrationEndDate`, `submissionStartDate`, `submissionEndDate`),
    these dates will now be extracted from `challenge.phases` array.

Reference topcoder-platform#4715, topcoder-platform#4716
@cagdas001 cagdas001 mentioned this issue Aug 11, 2020
Merged
@cagdas001
Copy link
Collaborator

PR: #4737

@Oanh-and-only-Oanh Oanh-and-only-Oanh added P3 Normal (resolved within 7 days) and removed P2 Important (resolve within 3 days) labels Aug 11, 2020
@SathyaJayabal SathyaJayabal added this to the V5 Challenge API v1.4 milestone Aug 13, 2020
cagdas001 added a commit to cagdas001/community-app that referenced this issue Aug 18, 2020
@cagdas001
fix(challenge-listing): sorting by dates & phase displaying
5cd686e 
* Add `phaseStartDate` and `phaseEndDate` helper functions at `challenge-detail/helper`
to get the correct start/end date of a phase.
* `TIME_TO_REGISTER`, `TIME_TO_SUBMIT` and `MOST_RECENT` sorting functions updated to reflect above change.
* `ProgressBarTooltip` and `ChallengeCard/Status` updated to display correct phase start/end dates.

Addresses topcoder-platform#4715, topcoder-platform#4716
@cagdas001 cagdas001 mentioned this issue Aug 18, 2020
Merged
@cagdas001
Copy link
Collaborator

New PR also updates the challenge listing page, so you'll see the correct phase start/end dates.

@lakshmiathreya lakshmiathreya added Need clarification Need clarification to proceed fixing the issue further Staging Env labels Aug 21, 2020
@lakshmiathreya lakshmiathreya removed the Beta Env Environment label Aug 21, 2020
@lakshmiathreya
Copy link

@SathyaJayabal The sort order seems same. Only end dates have changed. Pls clarify.
Screenshot 2020-08-21 at 11 34 15 AM
Screenshot 2020-08-21 at 11 34 26 AM
Uploading Screenshot 2020-08-21 at 11.35.07 AM.png…

@cagdas001
Copy link
Collaborator

@lakshmiathreya the most recent sorting sorts challenges by start date, in descending order. You should check the start dates of challenges.

@SathyaJayabal
Copy link
Collaborator Author

verified on staging
Screenshot 2020-08-27 at 5 36 07 PM

@SathyaJayabal SathyaJayabal removed tcx_ReadyForReview Need clarification Need clarification to proceed fixing the issue further labels Aug 27, 2020
@SathyaJayabal
Copy link
Collaborator Author

verified on staging(develop branch)
Screenshot 2020-08-28 at 1 40 43 PM

@SathyaJayabal SathyaJayabal added Prod Env Environment and removed Staging Env labels Aug 28, 2020
@SathyaJayabal
Copy link
Collaborator Author

verified on prod
Screenshot 2020-08-28 at 4 23 48 PM

@crazyk07
Copy link

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30136487

This is an automated message for crazyk via Topcoder X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cagdas001 cagdas001

Labels
Challenge Listing P3 Normal (resolved within 7 days) Prod Env Environment QA Pass tcx_Assigned tcx_FixAccepted tcx_Paid v5-intgration-sub-code
Projects
None yet
Milestone
v1.1.1
Development

No branches or pull requests
6 participants
@sushilshinde @cagdas001 @crazyk07 @Oanh-and-only-Oanh @lakshmiathreya @SathyaJayabal