Skip to content

[$50]Registration : Error on registering #4562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SathyaJayabal opened this issue Jun 18, 2020 · 15 comments
Closed

[$50]Registration : Error on registering #4562

SathyaJayabal opened this issue Jun 18, 2020 · 15 comments

Comments

@SathyaJayabal
Copy link
Collaborator

#4380 (comment)

@sushilshinde sushilshinde changed the title Registration : Error on registering [$40]Registration : Error on registering Jun 18, 2020
@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30130310 has been created for this ticket.

This is an automated message for crazyk via Topcoder X

@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30130310 has been updated - it has been assigned to luizrrodrigues.

This is an automated message for crazyk via Topcoder X

@luizrrodrigues
Copy link
Collaborator

@sushilshinde PR's is ready:
topcoder-platform/topcoder-react-lib#203
#4588


  • Updated terms to use V5 API

@SathyaJayabal Before we go with QA we'll need API fix, check bellow:

@rootelement When try to agree the term API return error Unauthorized, but the term was agreed, check:
}|

@rootelement
Copy link
Contributor

@ThomasKranitsas please check this at the start of your day

@sushilshinde
Copy link
Collaborator

@SathyaJayabal please wait for API for fix

@sushilshinde sushilshinde changed the title [$40]Registration : Error on registering [$50]Registration : Error on registering Jun 24, 2020
@rootelement
Copy link
Contributor

The problem that @ThomasKranitsas fixed is that the terms api wasn't failing correctly, it was proceeding to the next middleware. See here:
https://github.com/topcoder-platform/terms-service/pull/27/files

So while this will now throw an error when this call is made, we're not sure why that call should be failing. Can you give us steps to reproduce? You're calling with a JWT of what user? Is this in dev or prod?

@rootelement
Copy link
Contributor

FYI - we're almost done debugging this. We found the root of the issue and have tested most of it. Will update shortly.

@luizrrodrigues
Copy link
Collaborator

@rootelement cool, thanks.

Let me know if need more details.

@rootelement
Copy link
Contributor

@luizrrodrigues Please try now. All our tests pass in dev. I will be pushing to Prod momentarily.

@luizrrodrigues
Copy link
Collaborator

@rootelement Working well now. Thanks.

@sushilshinde @SathyaJayabal I'll need to do an additional fix in FE.

@luizrrodrigues
Copy link
Collaborator

@SathyaJayabal
Copy link
Collaborator Author

SathyaJayabal commented Jun 26, 2020

@luizrrodrigues @sushilshinde
1.
https://beta-community-app.topcoder.com/challenges/0084eae1-4eb9-4def-bf53-e39f13b6d12b
The "Standard terms for Topcoder Competitions V2.2" was displayed even though the user had already agreed to it previously in V4 (user picachui). When clicking on agree, the terms pop-up did not close as expected and the agree button was enabled again. Clicking on agree again, gives an api error that the user has already agreed. Please refer to screenshots and video.
Screenshot 2020-06-26 at 9 08 27 AM
termsV2.2.mov.zip

  1. On accessing the above challenge again and clicking on register, the user was able to register and the register button changed to unregister. But the registration tab is not displayed nor is the number of registrants updated on the listings page. This issue is happening only for few contests. Example:
    https://beta-community-app.topcoder.com/challenges/d06475ea-8b93-4998-820c-d55a96d16972
    https://beta-community-app.topcoder.com/challenges/0084eae1-4eb9-4def-bf53-e39f13b6d12b

Screenshot 2020-06-26 at 9 18 44 AM

Screenshot 2020-06-26 at 9 19 06 AM

  1. For a challenge requiring NDA (https://beta-community-app.topcoder.com/challenges/e77d97be-a576-4d62-966b-3a46b2d3f530) the NDA popup is displayed even though user (picachui) has already agreed to it previously (in V4)
    The terms are not displayed completely and there is no agree button to continue.

Screenshot 2020-06-26 at 9 09 25 AM

@SathyaJayabal SathyaJayabal added QA Fail QA verification on Dev has failed. Assignee to redo the fix. and removed Ready for QA labels Jun 26, 2020
@SathyaJayabal
Copy link
Collaborator Author

@sushilshinde , @luizrrodrigues lets track the above issues in separate tickets

@SathyaJayabal SathyaJayabal added QA Pass and removed QA Fail QA verification on Dev has failed. Assignee to redo the fix. labels Jun 26, 2020
@SathyaJayabal
Copy link
Collaborator Author

#4609
#4608
#4607

@crazyk07
Copy link

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30130310

This is an automated message for crazyk via Topcoder X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants