Skip to content

[$50]Registration: TC Competitions V2.2 Issue #4607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SathyaJayabal opened this issue Jun 26, 2020 · 13 comments
Closed

[$50]Registration: TC Competitions V2.2 Issue #4607

SathyaJayabal opened this issue Jun 26, 2020 · 13 comments

Comments

@SathyaJayabal
Copy link
Collaborator

https://beta-community-app.topcoder.com/challenges/0084eae1-4eb9-4def-bf53-e39f13b6d12b
The "Standard terms for Topcoder Competitions V2.2" was displayed even though the user had already agreed to it previously in V4 (user picachui). When clicking on agree, the terms pop-up did not close as expected and the agree button was enabled again. Clicking on agree again, gives an api error that the user has already agreed. Please refer to screenshots and video. Refreshing the page and then clicking on register works and the terms are not displayed again.
Uploading termsV2.2.mov.zip…
Screenshot 2020-06-26 at 9 08 27 AM

@sushilshinde
Copy link
Collaborator

@rootelement terms API v2 data not migrated to terms API v5 backend

@rootelement
Copy link
Contributor

@sushilshinde Terms data is not migrated regularly. There's no forward sync on it. Migration of terms happened back in April. When it's hooked up to v5, you'll have to agree to them again.

@sushilshinde sushilshinde changed the title Registration: TC Competitions V2.2 Issue [$50]Registration: TC Competitions V2.2 Issue Jun 26, 2020
@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30131348 has been created for this ticket.

This is an automated message for crazyk via Topcoder X

@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30131348 has been updated - it has been assigned to luizrrodrigues.

This is an automated message for crazyk via Topcoder X

@sushilshinde
Copy link
Collaborator

@SathyaJayabal this issue still relevant?

@luizrrodrigues
Copy link
Collaborator

@sushilshinde @SathyaJayabal Looks like this working well now.

Tested with my user in this challenge: https://beta-community-app.topcoder.com/challenges/891de470-97ad-4b9b-9a46-75a485dabb0e

@SathyaJayabal
Copy link
Collaborator Author

SathyaJayabal commented Jul 21, 2020

@sushilshinde , @luizrrodrigues verified this with both a new user who has not agreed to the terms and a user who has already agreed. Works well.
https://drive.google.com/file/d/18Ufk_H4xa4ejqYhZkq_IUOIfHN84UcJN/view?usp=sharing

@SathyaJayabal
Copy link
Collaborator Author

SathyaJayabal commented Jul 21, 2020

@sushilshinde @rootelement , user agreed to standard terms in V5 had to agree again in V4. Please confirm this is expected behaviour and that there is no sync between terms agreed in beta(v5 terms) and prod(v2 terms).

cc @lakshmiathreya

@SathyaJayabal SathyaJayabal added Need clarification Need clarification to proceed fixing the issue further and removed QA Pass labels Jul 21, 2020
@rootelement
Copy link
Contributor

There is no sync from v4 to v5, i have to run that manually. There is a legacy processor, so signing it in v5 should propagate to v4. I will check the terms processor.

@rootelement
Copy link
Contributor

@SathyaJayabal there was an issue in the legacy terms processor on validation of the kafka message body. I've fixed and deployed to dev and prod. Can you re-evaluate?

@SathyaJayabal SathyaJayabal added Ready for QA and removed Need clarification Need clarification to proceed fixing the issue further labels Jul 23, 2020
@SathyaJayabal
Copy link
Collaborator Author

@rootelement , user has agreed to standard terms in V5, but still is asked to agree in V4 again.
user: picachuitest2
Screenshot 2020-07-23 at 2 08 13 PM

@SathyaJayabal
Copy link
Collaborator Author

SathyaJayabal commented Jul 31, 2020

verified on beta. works as expected after the latest terms migration.

@crazyk07
Copy link

crazyk07 commented Aug 1, 2020

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30131348

This is an automated message for crazyk via Topcoder X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants