Skip to content

[$200]Registration issue for Challenges requiring NDA #4609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SathyaJayabal opened this issue Jun 26, 2020 · 52 comments
Closed

[$200]Registration issue for Challenges requiring NDA #4609

SathyaJayabal opened this issue Jun 26, 2020 · 52 comments

Comments

@SathyaJayabal
Copy link
Collaborator

For a challenge requiring NDA (https://beta-community-app.topcoder.com/challenges/e77d97be-a576-4d62-966b-3a46b2d3f530) the NDA popup is displayed even though user (picachui) has already agreed to it previously (in V4)
The terms are not displayed completely and there is no agree button to continue.
Screenshot 2020-06-26 at 9 09 25 AM

@SathyaJayabal SathyaJayabal added P0 Critical (resolve within 4 hours) and removed P1 Urgent (resolve within 24 hours) labels Jun 26, 2020
@sushilshinde sushilshinde changed the title Registration issue for Challenges requiring NDA NDA [$50]Registration issue for Challenges requiring NDA NDA Jun 26, 2020
@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30131350 has been created for this ticket.

This is an automated message for crazyk via Topcoder X

@crazyk07
Copy link

Contest https://www.topcoder.com/challenges/30131350 has been updated - it has been assigned to luizrrodrigues.

This is an automated message for crazyk via Topcoder X

@luizrrodrigues
Copy link
Collaborator

@rootelement V5 Terms missing docusignTemplateId to DocuSignable term type:

image

swagger file:
https://github.com/topcoder-platform/terms-service/blob/624ca31a830ab448af91c96776ba5ccd91336df1/docs/swagger.yaml#L204-L205

V2 return:
image

@rootelement
Copy link
Contributor

@luizrrodrigues i think this was due to the docusignable template id being wrong in the config. Deploying now and testing.

@rootelement
Copy link
Contributor

Looks like it works in dev:
Screen Shot 2020-06-30 at 10 41 45 AM

@luizrrodrigues
Copy link
Collaborator

@rootelement This returning well now, but now jump in a new issue:

  1. When try to request /v5/terms/docusignViewURL receiving this error:
    Login to DocuSign server failed.

image


  1. Looks like not need pass returnUrl anymore, but instead need pass tabs, can you help with this?

@lakshmiathreya lakshmiathreya changed the title [$50]Registration issue for Challenges requiring NDA NDA [$50]Registration issue for Challenges requiring NDA Jul 1, 2020
@rootelement
Copy link
Contributor

Status update here. Everything works except for the Docusign Callback. Working on that now.

@rootelement
Copy link
Contributor

This is unblocked from the API side. @luizrrodrigues is working on cleaning up the UI.

@sushilshinde
Copy link
Collaborator

@luizrrodrigues waiting for PR

@luizrrodrigues
Copy link
Collaborator

@sushilshinde I'm waiting for API fix.

@rootelement Working on this.

@luizrrodrigues
Copy link
Collaborator

@rootelement API returning error Requesting Signature via template failed.

image

@rootelement
Copy link
Contributor

I just tried that very same POST with my jcori dev account, which has these roles:

{
  "roles": [
    "copilot",
    "administrator",
    "Connect Admin",
    "Topcoder User"
  ],
  "iss": "https://api.topcoder-dev.com",
  "handle": "jcori",
  "exp": 1594221019,
  "userId": "40029484",
  "iat": 1594220419,
  "email": "[email protected]",
  "jti": "89df045b-89a7-405c-bc92-61cce1ac6cf4"
}

And it worked fine. I got the URL by POSTing from Postman, opened the url returned in the browser, signed the document, and was given the {'message': 'success'} return.

I was even notified of the signature because I own the demo instance:
Screen Shot 2020-07-08 at 11 04 27 AM

Can you please post your steps @luizrrodrigues ?

@mtwomey
Copy link
Contributor

mtwomey commented Jul 8, 2020

@luizrrodrigues / @sushilshinde Further notes:

Test Token

{
  "roles": [
    "Topcoder User"
  ],
  "iss": "https://api.topcoder-dev.com",
  "handle": "mtwomey40",
  "exp": 1594222439,
  "userId": "88773500",
  "iat": 1594221839,
  "email": "[email protected]",
  "jti": "1ae04bf5-4c87-4ab2-97ad-ef2af5920ab9"
}

Curl

curl --location --request POST 'https://api.topcoder-dev.com/v5/terms/docusignViewURL' \
--header 'Authorization: Bearer eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJyb2xlcyI6WyJUb3Bjb2RlciBVc2VyIl0sImlzcyI6Imh0dHBzOi8vYXBpLnRvcGNvZGVyLWRldi5jb20iLCJoYW5kbGUiOiJtdHdvbWV5NDAiLCJleHAiOjE1OTQyMjI0MzksInVzZXJJZCI6Ijg4NzczNTAwIiwiaWF0IjoxNTk0MjIxODM5LCJlbWFpbCI6Im10d29tZXk0MEBiZWFrc3Rhci5jb20iLCJqdGkiOiIxYWUwNGJmNS00Yzg3LTRhYjItOTdhZC1lZjJhZjU5MjBhYjkifQ.DMNtD3LHIqekIM6J4_zv2CrpC-ho9gRFTGfikvpRbZE' \
--header 'Content-Type: application/json' \
--header 'Cookie: tcsso=40029484|a1dbc7405f7186d4df353764b5bdeaf5a9d954a43d09c4ba4baad730f66818; tcjwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJuaWNrbmFtZSI6Impjb3JpIiwiZW1haWwiOiJqY29yaStkZXZAdG9wY29kZXIuY29tIiwibmFtZSI6Impjb3JpK2RldkB0b3Bjb2Rlci5jb20iLCJwaWN0dXJlIjoiaHR0cHM6Ly9zLmdyYXZhdGFyLmNvbS9hdmF0YXIvZTk0ODU2ZDAxMThmNjkwYjY2MWRjN2NjMWJjODFkOGY_cz00ODAmcj1wZyZkPWh0dHBzJTNBJTJGJTJGY2RuLmF1dGgwLmNvbSUyRmF2YXRhcnMlMkZqYy5wbmciLCJyb2xlcyI6WyJ1c2VyIl0sImFwcF9tZXRhZGF0YSI6eyJyb2xlcyI6WyJ1c2VyIl0sImF1dGhvcml6YXRpb24iOnsiZ3JvdXBzIjpbXX19LCJhdXRob3JpemF0aW9uIjp7Imdyb3VwcyI6W119LCJncm91cHMiOltdLCJjbGllbnRJRCI6IkpGRG83SE1rZjBxMkNrVkZIb2p5M3pIV2FmemlwcmhUIiwidXBkYXRlZF9hdCI6IjIwMjAtMDYtMTVUMjA6NDc6MzEuNzEzWiIsInVzZXJfaWQiOiJhdXRoMHw0MDAyOTQ4NCIsImlkZW50aXRpZXMiOlt7InVzZXJfaWQiOiI0MDAyOTQ4NCIsInByb3ZpZGVyIjoiYXV0aDAiLCJjb25uZWN0aW9uIjoiVEMtVXNlci1EYXRhYmFzZSIsImlzU29jaWFsIjpmYWxzZX1dLCJjcmVhdGVkX2F0IjoiMjAxNy0xMS0xMFQxOTowNzoxNi4xNDlaIiwiZW1haWxfdmVyaWZpZWQiOnRydWUsImlzcyI6Imh0dHBzOi8vdG9wY29kZXItZGV2LmF1dGgwLmNvbS8iLCJzdWIiOiJhdXRoMHw0MDAyOTQ4NCIsImF1ZCI6IkpGRG83SE1rZjBxMkNrVkZIb2p5M3pIV2FmemlwcmhUIiwiaWF0IjoxNTkyMjU0MDUzLCJleHAiOjE5NTIyNTQwNTN9.ZcLFfo2y--aJLRtc9NUaY97H-bsH73jJF0rOZJCNVwM' \
--data-raw '{ 
	"templateId": "7893116a-bf76-475a-b92e-3931c00902a1"
}'

Request Response (200)

{
    "recipientViewUrl": "https://demo.docusign.net/Signing/MTRedeem/v1/1a5b37c6-bcc5-48eb-a73c-8b0ce9e37560?slt=eyJ0eXAiOiJNVCIsImFsZyI6IlJTMjU2Iiwia2lkIjoiNjgxODVmZjEtNGU1MS00Y2U5LWFmMWMtNjg5ODEyMjAzMzE3In0.AQUAAAABAAMABwAAnT8hUyPYSAgAAPsP1FMj2EgYAAEAAAAAAAAAIQBdAwAAeyJUb2tlbklkIjoiYzMyZjkwZDAtOGYyMy00MzZhLWFlNTctN2Q1MDgxZGRkZjAxIiwiU3ViamVjdCI6bnVsbCwiU3ViamVjdFR5cGUiOm51bGwsIkV4cGlyYXRpb24iOiIyMDIwLTA3LTA4VDE1OjMwOjIyKzAwOjAwIiwiSXNzdWVkQXQiOiIyMDIwLTA3LTA4VDE1OjI1OjIyLjE3NDc4OTQrMDA6MDAiLCJSZXNvdXJjZUlkIjoiNzc1ZTViZDItZTg1MC00NjI0LThiYzItODFlZWJjYjI0ODBiIiwiTGFiZWwiOm51bGwsIlNpdGVJZCI6bnVsbCwiUmVzb3VyY2VzIjoie1wiRW52ZWxvcGVJZFwiOlwiNzc1ZTViZDItZTg1MC00NjI0LThiYzItODFlZWJjYjI0ODBiXCIsXCJBY3RvclVzZXJJZFwiOlwiNmJlZDVkYTctNDA3OC00N2Y3LTk1OGUtM2FmOTA4OWQ0ZDQ1XCIsXCJSZWNpcGllbnRJZFwiOlwiNmExNjBjZDMtODczMC00N2M2LWIxMDYtM2I2OTZkYjViZjRjXCIsXCJGYWtlUXVlcnlTdHJpbmdcIjpcInQ9MGM0ZWIyZjItMjRkZC00YzY2LWExZGMtNGQwMmQyZTIyYmY4XCJ9IiwiT0F1dGhTdGF0ZSI6bnVsbCwiVG9rZW5UeXBlIjoxLCJBdWRpZW5jZSI6IjI1ZTA5Mzk4LTAzNDQtNDkwYy04ZTUzLTNhYjJjYTU2MjdiZiIsIlNjb3BlcyI6bnVsbCwiUmVkaXJlY3RVcmkiOiJodHRwczovL2RlbW8uZG9jdXNpZ24ubmV0L1NpZ25pbmcvU3RhcnRJblNlc3Npb24uYXNweCIsIkhhc2hBbGdvcml0aG0iOjAsIkhhc2hTYWx0IjpudWxsLCJIYXNoUm91bmRzIjowLCJUb2tlblNlY3JldEhhc2giOm51bGwsIlRva2VuU3RhdHVzIjowLCJFeHRlcm5hbENsYWltc1JlcXVlc3RlZCI6bnVsbCwiVHJhbnNhY3Rpb25JZCI6bnVsbCwiVHJhbnNhY3Rpb25FdmVudENhbGxiYWNrVXJsIjpudWxsLCJJc1NpbmdsZVVzZSI6ZmFsc2V9.1_W0UAVwWntFN0AHc1BxgfKzmriN_SvehG6Li-ff-XqW33HrrFRW6jv0kffTWYt5E4GeJq-XG8Gjztg0lVLsYzBIVe70b4M2libYNSVGwIyv_VnQYs9XoEIB-MYsGXZsjoA1WsXMs9yY0NrAKiF6p3H_ZvyHeUeVyKuloF0kKbmoOg47TXS8BX-XkyZJsXy4lViaFPmbSzCLnpsieuC--xtUWPH5h2L_rl7cLiMG3xAhvdIIXYEGKRtyHc3JPNWN18zZP8V2JlYWulJ2S51skrax-FOfyqeuod7BzBjBWoAOUg3l-wkj_Dk7pbrE0uduHYv_Ofb1ADN6ga68hiiLfg",
    "envelopeId": "775e5bd2-e850-4624-8bc2-81eebcb2480b"
}

Process proceeds from there (and can be completed)
[Copy and paste return URL into browser]
image

@luizrrodrigues
Copy link
Collaborator

Let me check this again and back with the results.

@sushilshinde
Copy link
Collaborator

sushilshinde commented Jul 21, 2020

please share creds on slack for beta/proda

@luizrrodrigues
Copy link
Collaborator

luizrrodrigues commented Jul 21, 2020

@SathyaJayabal This happen after sign the DocuSign or before?

I mean, are you able to see the DocuSign frame?

@SathyaJayabal
Copy link
Collaborator Author

shared creds on slack @luizrrodrigues

@SathyaJayabal
Copy link
Collaborator Author

SathyaJayabal commented Jul 23, 2020

@luizrrodrigues , for a user who has not signed the NDA, the NDA document is displayed as expected. When the user signs and clicks on finish, the document loads again and the user is asked to sign again. This repeats and the the user is not able to proceed.

test challenge:https://beta-community-app.topcoder.com/challenges/0c8061f0-076f-47d3-a901-7cf13f99500c

Please see linked video for reference. user:CustomerUser (password shared on slack)
https://drive.google.com/file/d/1qZHPP-rU9qurIx4CTITryiVnH6YS6SA5/view?usp=sharing

@luizrrodrigues
Copy link
Collaborator

@SathyaJayabal Thanks

@rootelement FE receiving signing_complete from DocuSign, is BE getting an error? Looks like not updating the terms assigned.

@rootelement
Copy link
Contributor

rootelement commented Jul 23, 2020

Backend receiver in prod was having an error. I just was able to complete NDA for my user in prod just now:
https://beta-community-app.topcoder.com/challenges/0c8061f0-076f-47d3-a901-7cf13f99500c

Screen Shot 2020-07-23 at 4 12 31 PM

Please test again.

@sushilshinde
Copy link
Collaborator

@luizrrodrigues can you confirm and PR if there are changes?

@luizrrodrigues
Copy link
Collaborator

@rootelement Cool, looks good now.

@sushilshinde No changes needed, this was fixed in BE side.

@luizrrodrigues luizrrodrigues added Ready for QA and removed QA Fail QA verification on Dev has failed. Assignee to redo the fix. labels Jul 27, 2020
@SathyaJayabal
Copy link
Collaborator Author

@luizrrodrigues , not able to register for user who has already signed the NDA. Please try with your own handle and check please.

See linked video for reference.
https://drive.google.com/file/d/1xqBBNRuNRkqh71zFSsm4Vq0U5qaGXk5A/view?usp=sharing

A user who has not yet signed the NDA is able to sign and register to a challenge
attached video
https://drive.google.com/file/d/1X3yocguu1UT0mFHGKZY9r2ceHdF5_qjH/view?usp=sharing

@SathyaJayabal
Copy link
Collaborator Author

cc @sushilshinde

@SathyaJayabal SathyaJayabal added QA Fail QA verification on Dev has failed. Assignee to redo the fix. and removed Ready for QA labels Jul 27, 2020
@luizrrodrigues
Copy link
Collaborator

@rootelement Backend support viewing_complete event return from DocuSign?

viewing_complete is about to see already signed.

@rootelement
Copy link
Contributor

@SathyaJayabal what is your memberId in prod?

@luizrrodrigues
Copy link
Collaborator

@rootelement I see same issue with my user, id: 22827870

Challenge: https://beta-community-app.topcoder.com/challenges/658ae590-b249-4db0-bad4-b2ca86f31eda

@Oanh-and-only-Oanh Oanh-and-only-Oanh removed the QA Fail QA verification on Dev has failed. Assignee to redo the fix. label Jul 28, 2020
@SathyaJayabal
Copy link
Collaborator Author

@rootelement , See the same issue with another user drasticdpk. This behaviour may be common to all users who have already signed the NDA.

@rootelement rootelement changed the title [$150]Registration issue for Challenges requiring NDA [$200]Registration issue for Challenges requiring NDA Jul 28, 2020
@SathyaJayabal
Copy link
Collaborator Author

Verified for following users who have already signed NDA in V4 (callmekatootie, drasticdpk and kiril.kartunov ) and for users users who signed NDA in v5(picachuitest1) and users who have not yet signed NDA(picachuitest2).

Works fine for all cases.

@crazyk07
Copy link

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30131350

This is an automated message for crazyk via Topcoder X

@rootelement
Copy link
Contributor

Thank you @luizrrodrigues for your patience in testing this. And @SathyaJayabal for your awesome diligence on providing clear feedback.

@luizrrodrigues
Copy link
Collaborator

@rootelement No problem :)

@lakshmiathreya
Copy link

Code freeze Re-testing: Verified with member who has accepted NDA in v4 earlier (lakshmiathreya) and member who hadnt accepted earlier - accepted in v5 now (lakshmiaCopilot).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants