[$20]Registration: Challenge terms displayed even if the user has already agreed to the terms

[SathyaJayabal]

Registration: Challenge terms displayed even if the user has already agreed to the terms. Onclicking on agree nothing happens and the user cannot proceed to register. We see the following error in the api response
https://api.topcoder.com/v2/terms/21303/agree
https://beta-community-app.topcoder.com/challenges/adb02d6f-dcc6-4fcc-b7a4-a16c7d173839
user:picachui

Another example:https://beta-community-app.topcoder.com/challenges/d3886070-f6f7-4f23-81b5-9fb7e3272c06

[sushilshinde]

@topcoder-platform/topcodercompetitors @topcoder-platform/tcxcommunity this is open for pickup

Submit in 8 hours and PR to

https://github.com/topcoder-platform/community-app/tree/integration-v5-challenge-api
https://github.com/topcoder-platform/topcoder-react-lib/tree/integration-v5-challenge-api

run npm run test before PR

[crazyk07]

Contest https://www.topcoder.com/challenges/30130201 has been created for this ticket.

This is an automated message for crazyk via Topcoder X

[crazyk07]

Contest https://www.topcoder.com/challenges/30130201 has been updated - it has been assigned to cagdas001.

This is an automated message for crazyk via Topcoder X

[cagdas001]

What is the password of picachui user?

[cagdas001]

@sushilshinde @SathyaJayabal

What is the password of picachui user?

[rootelement]

Did you try appirio123?

[SathyaJayabal]

@cagdas001 , thats my production user id. Please use your handle.

[cagdas001]

Did you try appirio123?

@rootelement Yes I tried it, didn't work. The issue is that, the login link redirects me to the https://accounts.topcoder.com domain while the beta domain is actually https://beta-community-app.topcoder.com

I couldn't find a login link on beta instance so can't login with appirio123

[cagdas001]

@cagdas001 , thats my production user id. Please use your handle.

Okay, thank you. I thought it won't prompt me the dialog with my own username since I already agreed them before, but it did. Now I can reproduce

[SathyaJayabal]

@cagdas001 , thats my production user id. Please use your handle.

Okay, thank you. I thought it won't prompt me the dialog with my own username since I already agreed them before, but it did. Now I can reproduce

Yes, thats the error. The Front end prompts even when the user is already agreed to the terms. We need to check if the user is already agreed, before displaying the prompt.

[cagdas001]

Releasing as I'm currently having some issues with node-gyp on my Windows machine

[crazyk07]

Contest https://www.topcoder.com/challenges/30130201 has been updated - it has been assigned to PkDurlabhji.

This is an automated message for crazyk via Topcoder X

[sushilshinde]

@PrakashDurlabhji wait for confirmation on v5 terms API shift

[PrakashDurlabhji]

@sushilshinde shall I proceed with this?

[sushilshinde]

Yes use terms v5 api

[PrakashDurlabhji]

@sushilshinde working

[PrakashDurlabhji]

@SathyaJayabal was it ever working perfectly?

1. I remember when agreement used to be seen by me and I register than nothing happens.
2. then i refresh the challenge page and i am found to be registered. so is this expected flow?
3. also can you please give some test challenges where i may not have agreed yet.

[PrakashDurlabhji]

@sushilshinde I guess terms api not yet on V5 because this is not working

https://api.topcoder.com/v5/terms/detail/21303

Need clarification label was removed by me mistakenly.

[PrakashDurlabhji]

@SathyaJayabal @sushilshinde can anyone please raise a ticket v5 terms api migration on respective repo? Apology for removing need clarification label earlier

[SathyaJayabal]

@PrakashDurlabhji , please see below documentation for v5 terms api. https://github.com/topcoder-platform/terms-service/blob/dev/docs/swagger.yaml

[sushilshinde]

@luizrrodrigues can you also guide @PrakashDurlabhji in implementation as your issues also related.

[luizrrodrigues]

@PrakashDurlabhji Instead https://api.topcoder.com/v5/terms/detail/21303 you need to use https://api.topcoder-dev.com/v5/terms/b11da5cd-713f-478d-90f4-f679ef53ee95 to get details.

@sushilshinde I think this one is a duplication of #4562

Both issues need to update the terms to use V5 API.

[PrakashDurlabhji]

@sushilshinde thanks.

Also I am actively trying to make a call from postman.
and yes @luizrrodrigues I just debugged and found mapping that 'v2/terms/detail/21303' is now v5/terms/{termsOfUseId}'.

@SathyaJayabal @luizrrodrigues I do not find in swagger https://github.com/topcoder-platform/terms-service/blob/dev/docs/swagger.yaml
the api to get all terms of challenge by challengeId.

1. In prod rite now there is a call to get challenge terms
   this.private.api.get(/terms/${challengeId}?role=Submitter)

2. and then after selecting a termuseOfid from above response we call 'v2/terms/detail/21303' in prod.

3. so mapping of 'v2/terms/detail' is there in v5, but what about this 'v2/terms/${challengeId}?role=Submitter'?

I am stuck here

[PrakashDurlabhji]

@SathyaJayabal @sushilshinde @luizrrodrigues

Though I feel its not correct usage of api, I am bit confused.

1. I just tried in POSTMAN https://api.topcoder.com/v5/terms?legacyId=30130750
   and passed tokenV3 in authorization .
2. It says "You are not allowed to perform this action".

I feel everything is smooth for terms details but not for getting all terms of a challenge.

[PrakashDurlabhji]

@SathyaJayabal waiting for endpoint

just for note down: http://localhost:3000/challenges/847bc43a-53c1-4cdd-a2ac-d3a7eb5ee25c

[rootelement]

You need to use the array of terms on the challenge response, then call the terms api for details. Right now there's no multi-id filter, so you'll have to hit it for each. The order of operations here should be:

1. Filter the challenge's terms on roleId for submitter
2. Loop through those terms IDs calling the terms api

This is similar to how it's done in the resources api:

https://github.com/topcoder-platform/resources-api/blob/b5c242e00bdfab55a49ba2d4e25d7a23dacd2aa7/src/services/ResourceService.js#L158

https://github.com/topcoder-platform/resources-api/blob/cfa7b62938fbf6daee4a44ad3a745566fcc08ba7/src/common/helper.js#L430

[luizrrodrigues]

@PrakashDurlabhji Please check about duplication with @sushilshinde
I'm already implementing this in issue #4562

[crazyk07]

Payment task has been updated: https://software.topcoder.com/review/actions/ViewProjectDetails?pid=30130201

This is an automated message for crazyk via Topcoder X