-
Notifications
You must be signed in to change notification settings - Fork 2
V1.0.0 #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
V1.0.0 #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copied from SAAR-R5 library, replaced `SARA_R5` with `UBLOX_AT` for now
Placeholders for now
Just includes all other headers in library
This is purely for backwards compatibility with the original library, mainly macros and constants. Some are duplicates in base class header, need to remove those
Copied from original SARA-R5 library, and modified to work with new library.
More consistent with the new library name, and more consistent with the GNSS library (UBX_GNSS is a common prefix there; probably not important to have parity between this and that, but hey, you never know when little things like that will help in big ways...)
Only in SparkFun_u-blox_SARA-R5_Arduino_Library.h
Prepping for merge
Fix backwards compatibility with original SARA-R5 library
Sub classes will need these things
Add voice class
Audio class (and other feature sets) now uses templating instead of virtual inheritance
Change to template structure
Not all modules support 9600, 115200 is a better default
Remove "SARA" references to keep it generic Add "Beginning..." print message to aid user in case module doesn't connect, which results in no messages for a long time
LARA_R6 does not support these AT commands, as per #4 Moved into SARA-R5 class for now, but if other modules support these, they should be moved into a sub-class that can be inherited like the voice class
Should just use macros to not have duplicate definitions Also remove PSD and UTIME definitions due to existence in sara_r5.h
Had to modify ping() from the base class due to LARA-R6 not providing a TTL value
Clock is very simple, should be before Ping and SMS examples
Allows us to use a single base class in audio examples instead of a specific module Need to update name at some point as part of #9, it's not clear if UBX_CELL_VOICE or UBX_CELL_VOICE_BASE should be used based on the names alone
Also default tone_id and nof_repeat to 0 in playAudioResource()
Now uses a vector to store individual URC handlers, and iterate through each one by one Also uses a separate vector for the URC strings within pruneBacklog This should make the URCs easier to maintain and expand, particularly within derived classes
Pending #16, this should work after that gets merged
Refactor URC handling
Just for the rare chance that someone is using the ATMega2560 with the original bootloader, triple exclamation marks would cause bad things. Easy enough to avoid by spacing them out!
Add audio examples
Add first examples
Clang formatter in VS Code set to Microsoft style
Clang formatter in VS Code set to Microsoft style
Many command and response arrays are fixed length, so no need to use calloc. This helps prevent the heap from getting fragmented.
clang with Microsoft style
Format library
Add MQTT Example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.