Skip to content

Move module specific features out of base class #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sfe-SparkFro opened this issue Nov 17, 2023 · 0 comments
Closed

Move module specific features out of base class #4

sfe-SparkFro opened this issue Nov 17, 2023 · 0 comments

Comments

@sfe-SparkFro
Copy link
Collaborator

The LARA-R6 does not support the following AT commands:

const char UBX_CELL_MESSAGE_PDP_CONFIG[] = "+UPSD"; // Packet switched Data Profile configuration
const char UBX_CELL_MESSAGE_PDP_ACTION[] = "+UPSDA"; // Perform the action for the specified PSD profile

const char UBX_CELL_NETWORK_ASSIGNED_DATA[] = "+UPSND"; // Packet switched network-assigned data

const char UBX_CELL_GNSS_REQUEST_TIME[] = "+UTIME"; // Ask for time information from cellular modem (CellTime)
const char UBX_CELL_GNSS_TIME_INDICATION[] = "+UTIMEIND"; // Time information request status unsolicited indication
const char UBX_CELL_GNSS_TIME_CONFIGURATION[] = "+UTIMECFG"; // Sets time configuration

Corresponding methods/structs/enums/etc. should be moved into sfe_sara_r5.h for now. If we add support for other modules that support those AT commands, then those should instead be moved into an intermediate class between the base and the module classes.

sfe-SparkFro added a commit that referenced this issue Dec 4, 2023
LARA_R6 does not support these AT commands, as per #4
Moved into SARA-R5 class for now, but if other modules support these, they should be moved into a sub-class that can be inherited like the voice class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant