Add first examples #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Had to modify ping() from the base class due to LARA-R6 not providing a TTL value
Clock is very simple, should be before Ping and SMS examples
gigapod
approved these changes
Dec 5, 2023
PaulZC
approved these changes
Dec 13, 2023
There was a problem hiding this comment.
The SARA-R5 does need the PDP / PSD stuff to set up its data connection... I'm fine with you creating a SARA-specific examples folder and copying in a subset of the examples from the SARA-R5 library. I will help you refactor them and test them when I get some spare time.
|
Gotcha. In that case, I agree, let's create a SARA-specific examples folder to handle that. Should do it in a separate PR, so I'll merge this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied some simpler examples from the SARA-R5 library and tweaked as needed to work with this library. Might want to add more examples before merging this in, @PaulZC which do you think would be best to add? I might ask for your help in testing.
Also, thoughts on having examples in sub-folders? For example, could have audio examples in one folder, GNSS examples in another, etc. Not something I've done before, so not sure how we want to go about naming.