Add voice class #6
Conversation
|
FYI I've written this to use virtual inheritance. The reason is because I anticipate various modules having different feature sets that we'll need to be able to select as needed (eg. module 1 needs feature set A, module 2 needs feature set B, and module 3 needs both A and B), and this allows us to do that. However there are some concerns about it, I believe with regards to performance and compatibility with different platforms. Interesting Reddit discussion here that I haven't had a chance to read through yet. |
There was a problem hiding this comment.
This looks good to my eyes. I assume you've tested it?! ;-)
It would be a good idea to add a compile-sketch workflow so you can check your example compiles successfully on multiple platforms.
|
Talked with @gigapod and we're gonna architect this a bit differently. Should still be backwards compatible with the original library, but it will avoid the diamond pattern so no virtual inheritance is needed. I'm going to merge this in for now just so I don't lose the code or have to deal with too many branches 😉 |
Resolves #5