Skip to content

Fix code style #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sfe-SparkFro opened this issue Dec 4, 2023 · 2 comments
Closed

Fix code style #9

sfe-SparkFro opened this issue Dec 4, 2023 · 2 comments

Comments

@sfe-SparkFro
Copy link
Collaborator

From @gigapod in #8:

for the internal classes/templates, can we move to a CamelCase class name, not the YELLING_AT_YOU format? Minor, but more approachable and modern.

Also, should run everything through a formatter
This was referenced Dec 4, 2023
Merged
Merged
@sfe-SparkFro
Copy link
Collaborator Author

Also from @gigapod in #10:

File should use 4 char spacing, not 2

sfe-SparkFro added a commit that referenced this issue Dec 12, 2023
@sfe-SparkFro
Create base voice class
8ea8b84 
Allows us to use a single base class in audio examples instead of a specific module
Need to update name at some point as part of #9, it's not clear if UBX_CELL_VOICE or UBX_CELL_VOICE_BASE should be used based on the names alone
@sfe-SparkFro sfe-SparkFro mentioned this issue Dec 13, 2023
Merged
@sfe-SparkFro
Copy link
Collaborator Author

Fixed by #18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sfe-SparkFro