Skip to content

Fixed remove_search_analytics issue #6447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 9, 2019
Merged

Fixed remove_search_analytics issue #6447

merged 2 commits into from
Dec 9, 2019

Conversation

keshavvinayak01
Copy link
Contributor

@keshavvinayak01 keshavvinayak01 commented Dec 8, 2019 •
edited by stsewd
Loading

This pull request references the issue #6349.
Changes :

  • Removed SEARCH_ANALYTICS flag from feature-flags
  • Removed SEARCH_ANALYTICS property from the Feature class under project/models.py
  • Removed 'Enable search analytics' tuple from the Feature object.

Closes #6217

@keshavvinayak01 keshavvinayak01 mentioned this pull request Dec 8, 2019
Closed
stsewd
stsewd reviewed Dec 9, 2019
View reviewed changes
Copy link
Member

@stsewd stsewd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, you still need to update some tests that were using the flag.

@keshavvinayak01
Copy link
Contributor Author

Thanks, you still need to update some tests that were using the flag.

Cool, I'll look into it.

stsewd
stsewd approved these changes Dec 9, 2019
View reviewed changes
Copy link
Member

@stsewd stsewd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Happy to get this issue finally closed

@stsewd stsewd merged commit f20832c into readthedocs:master Dec 9, 2019
This was referenced Dec 9, 2019
Closed
Closed
@stsewd stsewd mentioned this pull request Jan 9, 2020
Closed
Parth1811 added a commit to Parth1811/readthedocs.org that referenced this pull request Jan 9, 2020
@Parth1811
Fixes readthedocs#6510 -- Removed the show_analytics checks from th…
d147839 
…e template

This patch removes the check of `show_analytics` variable in
`templates/projects/project_search_analytics.html` which were expected after
fixing readthedocs#6447
Parth1811 added a commit to Parth1811/readthedocs.org that referenced this pull request Jan 9, 2020
@Parth1811
Fixes readthedocs#6510 -- Removed the show_analytics checks from th…
e94fb4c 
…e template

This patch removes the check of `show_analytics` variable in
`templates/projects/project_search_analytics.html` which were expected after
fixing readthedocs#6447
@Parth1811 Parth1811 mentioned this pull request Jan 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stsewd stsewd stsewd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove SEARCH_ANALYTICS Feature Flag
2 participants
@keshavvinayak01 @stsewd