remove search_analytics #6349
Closed
remove search_analytics #6349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stsewd
reviewed
Nov 5, 2019
|
The flag still needs to be removed from the docs. You can run the tests locally to check that everything is working https://docs.readthedocs.io/en/stable/development/tests.html in your PR |
|
I ran the test locally, there is a problem in doc_extensions.py, desc variable is referenced before assignment. What should i do? |
There is a reference to the setting in the docs, that should be removed. |
|
This was already done in #6447 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have removed the search_analytics flag, but i think the function is needed so didn't change the view.
Closes #6217