-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Remove SEARCH_ANALYTICS
Feature Flag
#6217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I want to resolve this issue. Can you tell me how I proceed for it. |
You need to remove this readthedocs.org/readthedocs/projects/models.py Line 1446 in 58f833d
And search the code to find where else its been used. and remove it in those places as well. |
Ok. |
@dojutsu-user can i take up this issue , do i have to remove this from all the files or just manage.py?? |
@KartikKapil you need to remove the flag from all files. You can take this PR as reference #6245 |
@stsewd there are still any mistake on that PR ? |
@keshav2212 test should pass, you can check the errors on the travis output, or running the tests locally https://docs.readthedocs.io/en/stable/development/tests.html |
@dojutsu-user This issue is still open right? |
@dojutsu-user @stsewd can you confirm that this solved the issue? #6447 |
Remove
SEARCH_ANALYTICS
Feature FlagRef: #6192 (comment)
The text was updated successfully, but these errors were encountered: