Skip to content

Remove SEARCH_ANALYTICS Feature Flag #6217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dojutsu-user opened this issue Sep 30, 2019 · 9 comments · Fixed by #6447
Closed

Remove SEARCH_ANALYTICS Feature Flag #6217

dojutsu-user opened this issue Sep 30, 2019 · 9 comments · Fixed by #6447
Labels
Accepted Accepted issue on our roadmap Good First Issue Good for new contributors Improvement Minor improvement to code

Comments

@dojutsu-user
Copy link
Member

Remove SEARCH_ANALYTICS Feature Flag

Ref: #6192 (comment)

@dojutsu-user dojutsu-user added Improvement Minor improvement to code Accepted Accepted issue on our roadmap labels Sep 30, 2019
@stsewd stsewd added the Good First Issue Good for new contributors label Sep 30, 2019
@keshav2212
Copy link

I want to resolve this issue. Can you tell me how I proceed for it.

@saadmk11
Copy link
Member

saadmk11 commented Oct 4, 2019

You need to remove this

SEARCH_ANALYTICS = 'search_analytics'

And search the code to find where else its been used. and remove it in those places as well.

@keshav2212
Copy link

Ok.

@KartikKapil
Copy link
Contributor

@dojutsu-user can i take up this issue , do i have to remove this from all the files or just manage.py??

@stsewd
Copy link
Member

stsewd commented Nov 4, 2019

@KartikKapil you need to remove the flag from all files. You can take this PR as reference #6245

@keshav2212
Copy link

@stsewd there are still any mistake on that PR ?

@stsewd
Copy link
Member

stsewd commented Nov 5, 2019

@keshav2212 test should pass, you can check the errors on the travis output, or running the tests locally https://docs.readthedocs.io/en/stable/development/tests.html

@keshavvinayak01
Copy link
Contributor

@dojutsu-user This issue is still open right?

@keshavvinayak01
Copy link
Contributor

@dojutsu-user @stsewd can you confirm that this solved the issue? #6447

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Good First Issue Good for new contributors Improvement Minor improvement to code
Projects
None yet
6 participants