Fixed ticket_6217 #6245
Closed
Fixed ticket_6217 #6245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stsewd
reviewed
Oct 6, 2019
|
ok..so now should I close this pull request ? |
|
No, you should push your new changes on this branch |
|
ok, then I need to create new pull request ? |
|
No, this pull request is updated when you push new changes. You should check https://opensource.guide/how-to-contribute/#opening-a-pull-request |
|
Here, I am again tried to remove 'Search_Analytics' Flag. Can you give review on this ? |
stsewd
reviewed
Oct 23, 2019
| url( | ||
| r'^(?P<project_slug>[-\w]+)/search-analytics/$', | ||
| SearchAnalytics.as_view(), | ||
| name='projects_search_analytics', |
There was a problem hiding this comment.
Only the flag should be removed, not the functionality
|
can you review it ? |
|
This was done in #6447 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am new towards contributions and I have tried to solve this problem.