Request to enable SEARCH_ANALYTICS feature flag for project frc-docs

[Daltz333]

Details

• Read the Docs project URL: https://frc-docs.readthedocs.io/
• Build URL (if applicable): https://github.com/wpilibsuite/frc-docs
• Read the Docs username (if applicable): Daltz333

[stsewd]

This feature should have been already live after #6447. Looks like we forgot to remove the show_analytics check in the template

https://github.com/readthedocs/readthedocs.org/blob/master/readthedocs/templates/projects/projects_search_analytics.html

[Parth1811]

Hey, I would like to fix this. May need some help though :)
Correct me if I'm wrong, do we simply have to remove this if condition and delete the else block. Essentially always executing the if block

readthedocs.org/readthedocs/templates/projects/projects_search_analytics.html

Lines 14 to 58 in 013f7be

	{% if show_analytics %}
	<h3>{% trans "Top queries" %}</h3>
	<div class="module-list">
	<div class="module-list-wrapper">
	<ul class="long-list-overflow">
	{% for query, count in queries %}
	<li class="module-item">
	{{ query }}
	<span class="right quiet">
	{{ count }} search{{ count|pluralize:"es" }}
	</span>
	</li>
	{% empty %}
	<li class="module-item">
	<p class="quiet">
	{% trans 'No date available.' %}
	</p>
	</li>
	{% endfor %}
	</ul>
	</div>
	</div>
	<br/>
	{% if query_count_of_1_month.labels and query_count_of_1_month.int_data %}
	<h2>{% trans "Overview of the past 1 month:" %}</h2>
	<canvas id="analytics-chart-last-7-days" width="400" height="150"></canvas>
	{% endif %}
	<br />
	<form method="get">
	<button type="submit" name="download" value="true">{% trans "Download all data" %}</button>
	</form>
	{% else %}
	<p class="empty">
	{% blocktrans trimmed %}
	Hey there! This feature is currently in beta state and is available under a
	<a href='https://docs.readthedocs.io/page/guides/feature-flags.html#available-flags'>feature flag</a>.
	In case you want to test this feature and help giving us feedback,
	please contact us via
	<a href='https://github.com/readthedocs/readthedocs.org/issues/new?title=Request%20to%20enable%20SEARCH_ANALYTICS%20feature%20flag%20for%20project%20{{ project }}'>GitHub issues</a>.
	{% endblocktrans %}
	</p>
	{% endif %}

[stsewd]

@Parth1811 yes. There is another check for show_analytics in that file that should be removed as well.

[Parth1811]

Ok got it.

readthedocs.org/readthedocs/templates/projects/projects_search_analytics.html

Line 73 in 013f7be

{% if query_count_of_1_month.labels and query_count_of_1_month.int_data and show_analytics %}