Add feature flip for always upgrading user defined packages on pip install #3201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, use a new pattern for API instance objects
Also, add a convenience method on the Project model for feature flag dependent values.
Installs the user-provided requirements with the `--upgrade` flag.
This allows for features on deprecated code, where we can say the feature is true historically.
Conflicts: readthedocs/doc_builder/python_environments.py
Conflicts: readthedocs/doc_builder/python_environments.py readthedocs/projects/models.py
…grade Conflicts: readthedocs/projects/models.py
…grade Conflicts: readthedocs/projects/models.py
ericholscher
approved these changes
Oct 31, 2017
Conflicts: readthedocs/doc_builder/python_environments.py readthedocs/projects/models.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're not yet sure if this will blow up user defined requirements, feature
here will be used to test on a sample.
Refs #3077
Closes #3077
Requires #3194
Requires #3200