Skip to content

Enable PIP_ALWAYS_UPGRADE feature #4156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wmayner opened this issue May 28, 2018 · 5 comments
Closed

Enable PIP_ALWAYS_UPGRADE feature #4156

wmayner opened this issue May 28, 2018 · 5 comments
Assignees
Labels
Support Support question

Comments

@wmayner
Copy link
Contributor

wmayner commented May 28, 2018

The project feature PIP_ALWAYS_UPGRADE was merged in PR #3201. I'm wondering if it's possible to use this feature as a user; it looks like it's not exposed yet.

@wmayner wmayner added the Support Support question label May 28, 2018
@stsewd
Copy link
Member

stsewd commented May 28, 2018

The features options are set by the rtd team by user requesting it. This could be an option for #4084

@wmayner
Copy link
Contributor Author

wmayner commented May 29, 2018

Oh, gotcha—didn't realize that!

In that case, I'd like to enable it for my project: https://pyphi.readthedocs.io (username wmayner)

@humitos humitos self-assigned this May 30, 2018
@humitos
Copy link
Member

humitos commented May 30, 2018

@wmayner Hi! I already added this feature to your project.

I'm closing the issue here, but let us know if it does worked as you expected or not and feel free to re-open it.

Thanks!

@humitos humitos closed this as completed May 30, 2018
wmayner added a commit to wmayner/pyphi that referenced this issue May 30, 2018
My fork `sphinx_rtd_theme` handles everything but the logo

Trying this again after RTD switched on the `PIP_ALWAYS_UPGRADE` flag
for the project: readthedocs/readthedocs.org#4156
@wmayner
Copy link
Contributor Author

wmayner commented May 30, 2018

Thanks! It looks like the upgrade flag is working.

I'm still not getting the behavior I expect, however (maybe this should be a separate issue—let me know):

I have my own fork of sphinx_rtd_theme, and I'm trying to get the styles from my fork to override the default styles on readthedocs.org. But it looks like the theme.css that's served is still the upstream version.

Maybe I'm misunderstanding how the styles are applied? Or maybe it's a caching issue? Any help would be appreciated.

@wmayner wmayner reopened this May 30, 2018
@humitos
Copy link
Member

humitos commented May 30, 2018

I just check this build output (https://readthedocs.org/projects/pyphi/builds/7268449/) and the feature that I added to your project worked since I can see the --upgrade option passed to pip.

Regarding the css: yes, that seems to be a different issue. Please, open a new one (and close this one) so we can track it there. We will need to research a little more to solve that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Support Support question
Projects
None yet
Development

No branches or pull requests

3 participants