Skip to content

Support --upgrade flag for pip installs #3027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wmayner opened this issue Aug 1, 2017 · 2 comments
Closed

Support --upgrade flag for pip installs #3027

wmayner opened this issue Aug 1, 2017 · 2 comments
Labels
Improvement Minor improvement to code Support Support question

Comments

@wmayner
Copy link
Contributor

wmayner commented Aug 1, 2017

Details

I'm using my own fork of sphinx_rtd_theme, but since the upstream version has already been installed by the time the project-specific requirements are installed, my fork is ignored because pip thinks that sphinx_rtd_theme is up-to-date.

This could be fixed by:

  1. Keeping my fork's version higher than the upstream;
  2. Giving it a different name;
  3. Putting my fork directly in the project repository via e.g. git subtree;
  4. Passing the --upgrade flag to the project-specific pip install.

(1) seems like a hack; (2) is also a hack; (3) is inelegant, since the theme already has a nice way of being required as a dependency, and subtrees are a pain anyway. So (4) seems like the best option, unless it would lead to problems on the RTD side.

Happy to submit a PR if this seems like a reasonable idea (pointing me to the relevant sections of the code would be helpful—I think it's readthedocs/doc_builder/python_environments.py?)

@wmayner wmayner added Improvement Minor improvement to code Support Support question labels Sep 12, 2017
@stsewd
Copy link
Member

stsewd commented Jan 7, 2018

I think this was already solved here #3201

@stsewd
Copy link
Member

stsewd commented Apr 16, 2018

This issue was already solved on #3201 (merged) as a continuation of #3077

@stsewd stsewd closed this as completed Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Minor improvement to code Support Support question
Projects
None yet
Development

No branches or pull requests

2 participants