Use --upgrade flag for user environment pip install
#3077
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Installs the user-provided requirements with the `--upgrade` flag.
wmayner
changed the title
--upgrade flag for user environment pip install--upgrade flag for user environment pip install
|
@ericholscher, by the way, I'd be happy to help out triaging tickets—would you grant me the necessary permissions? |
|
Sure thing. I added you. I know there is a reason we removed the call to |
|
Sounds good. Thanks for the permissions! |
wmayner
added
PR: ready for review
Support
|
I vaguely recall a problem with pip package caching while forcing upgrades. I'm going to bump up plans to test out feature flagging on projects this week. This is yet another case where we could push out a change on a sample and see if it blows up. |
|
@agjohnson, sounds good! Let me know if I can help. |
agjohnson
added a commit
that referenced
this pull request
Oct 31, 2017
…stall (#3201) * Add feature flipping models to Projects, plus example feature flip Also, use a new pattern for API instance objects * Refactoring the make_api_* calls into the API models * Add migrations for proxy models * Add some admin features * Bump setuptools version. * Add feature flip for setuptools latest version Also, add a convenience method on the Project model for feature flag dependent values. * Use `--upgrade` instead of `-U` in `pip` args * Add upgrade flag to user environment pip install Installs the user-provided requirements with the `--upgrade` flag. * Add feature flip for always upgrading user defined packages on pip install We're not yet sure if this will blow up user defined requirements, feature here will be used to test on a sample. Refs #3077 Closes #3077 * Rework feature relationship, add default true value based on date This allows for features on deprecated code, where we can say the feature is true historically. * Fix some issues, more tests * Rename Feature.feature -> Feature.feature_id, other cleanup * Drop setuptools pinning * Use semver for setuptools version * Missed merge conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #3027.
I'm not sure if this will cause undesirable side-effects, so more discussion is needed—but I figured I'd make the PR in any case.