Add feature flip for setuptools latest version #3200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, use a new pattern for API instance objects
Also, add a convenience method on the Project model for feature flag dependent values.
This allows for features on deprecated code, where we can say the feature is true historically.
Conflicts: readthedocs/doc_builder/python_environments.py
Conflicts: readthedocs/doc_builder/python_environments.py readthedocs/projects/models.py
ericholscher
approved these changes
Oct 31, 2017
| self.project.get_feature_value( | ||
| Feature.USE_SPHINX_LATEST, | ||
| 'sphinx<2', | ||
| 'sphinx==1.5.6', |
There was a problem hiding this comment.
I like this pattern, more explicit. Could maybe use kwargs here, to make it more obvious what the options are.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, add a convenience method on the Project model for feature flag
dependent values.
Closes #3171
Requires #3194