Skip to content

Bump setuptools version. #3171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Bump setuptools version. #3171

wants to merge 1 commit into from

Conversation

bhearsum
Copy link

Similar to #2547, setuptools is out of date again, and is causing builds such as https://readthedocs.org/projects/mozilla-balrog/builds/6136328/ to fail.

@bhearsum
Copy link
Author

@ericholscher - I'm not sure if you're the right person to pull in, but I see you were involved in #2547 - can you look at this?

@agjohnson
Copy link
Contributor

Thanks for the bump here. Noted in the other PR that updates setuptools, we need to do more testing here and will likely want to wrap this version bump in a feature flag to make sure we don't blow up everyone's builds. I think we can probably roll with this PR instead of #3100, as this is more current.

@agjohnson agjohnson added Needed: patch A pull request is required Needed: tests Tests are required and removed PR: ready for review labels Oct 23, 2017
@bhearsum
Copy link
Author

Sounds good to me!

@agronholm
Copy link
Contributor

Why does this need a feature flag? Anyone who wants to upgrade their setuptools can already do this without additional features, by specifying a minimum version in their requirements.txt. That's how I worked around the problem in my own projects.

@agjohnson
Copy link
Contributor

Anyone can upgrade at their own will now. Forcing new setuptools on 40k projects takes operations planning, unless we limit the sample size to who gets the new versions forced on their project. This is where feature flags come in.

Curious, are you forcing the latest setuptools on your projects now without any incident so far?

@agronholm
Copy link
Contributor

I am. Setuptools will have to be upgraded at some point. What good will it do to delay the inevitable?

@agronholm
Copy link
Contributor

Also, what exactly would that feature flag do?

@agjohnson
Copy link
Contributor

@agronholm it allows us to only force the new setuptools version on a small sample. We'll then increase the sample size if no issues are surfacing. All this allows us to limit the amount of breakage and allow operations to move substantially quicker for minor changes like this.

@agronholm
Copy link
Contributor

Oh, I see. I thought it was going to be a voluntary thing. Hence the confusion. So how will you decide who to force it on?

@agjohnson
Copy link
Contributor

Features can be forced on a sample, opt-in, or some mix of the two -- though we lack a strong pattern for opt-in just yet. For this feature, we'll do a random sampling, and anyone else that wants inclusion can get it on their project too.

@agronholm
Copy link
Contributor

Okay, this works for me. Anything as long as it gets done in the end :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needed: patch A pull request is required Needed: tests Tests are required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants