Skip to content

Upgrade setuptools to 36.5.0 #3100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

agronholm
Copy link
Contributor

This allows projects to specify their metadata in setup.cfg instead of setup.py.

This allows projects to specify their metadata in setup.cfg instead of setup.py.
@ericholscher
Copy link
Member

The Travis fail is invalid -- but have you tested this locally? I'm a little hesitent to futz with setuptools by itself, without the other related bits (virtualenv, pip, etc)

@agronholm
Copy link
Contributor Author

Do you want me to upgrade the other tools as well?

@agjohnson
Copy link
Contributor

@agronholm do you think there is any reason the current versions would be at odds with the new setuptools? we should be running more recent versions of each of the tools, but I'm not sure it makes a difference to us to upgrade in unison.

I'm playing around more with package configuration in setup.cfg in other projects, it's a rather nice alternative to setup.py 🙂

@agronholm
Copy link
Contributor Author

No, I don't. If upgrading setuptools to the latest version had negative repercussions, all hell would've broken loose elsewhere. I've seen those situations with at least setuptools and requests.
On another note, I will update the PR to the latest setuptools.

@agronholm agronholm changed the title Upgrade setuptools to 36.4.0 Upgrade setuptools to 36.5.0 Oct 4, 2017
@agronholm
Copy link
Contributor Author

@ericholscher seems like Travis passes now, so do you still need me to run some checks locally?

@ericholscher
Copy link
Member

Yea, travis is just code checks, this change will likely only effect actual builds, which is a hard thing to test in CI. This is another good use as @agjohnson mentioned for feature flags, would be nice to roll this out conditionally, and make sure it doesn't blow up on random environments.

@agjohnson
Copy link
Contributor

#3171 bumps this again, will continue my work there.

I have a feature flag branch i'll be prepping for review today. We should be able to get this out with a basic feature flag so we're not indiscriminately forcing latest setuptools on projects. I'll follow up with a feature flag addition on #3171

@agjohnson agjohnson closed this Oct 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants