-
Notifications
You must be signed in to change notification settings - Fork 70
Backport version tests to 7.x #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since this is at the top of the Dockerfile this avoid us to share layers between different docker images even if the image share most of it.
4.7.12.1 drastically increases memory usage, causing a lot of projects using conda to fail.
Downgrade conda - port to master
…to humitos/pin-python-dependencies
We are now pinning Miniconda to an specific version instead of always trying to use latest.
Remove test for miniconda sha
We should not update them anymore. Python2 is not supported anymore. setuptools 44.0.0 is the last version supported on Python2. Pinning also pip and virtualenv to avoid future problems.
Pin Python core dependencies (virtualenv, pip, setuptools)
Having them close to the bottom allow us to share most of the layer from the Docker images even after a Python version was updated
Conda has been doing the package we updated the most in the last months. So, it may be good to have it the closest to the bottom as possible.
PIP_VERSION and VIRTUALENV_VERSION are sensible variables that are read by pip and virtualenv respectively and we already have issues with them. So, to avoid this problem and future ones, we are prefixing all of our variables with `RTD_`.
Prefix all of our variables with `RTD_` to avoid issues
Suppress no test ran exit code when running 0 tests
…to humitos/move-env-labels-to-bottom
Just correcting template folder navigation with 'cd template/docs'
Updating CONTRIBUTING.rst template managing
Co-authored-by: Manuel Kaufmann <[email protected]>
Added Rust to the build image
Since we are upgrading the Docker image version, it's good to be prepared to have a newer Python version as well. We can start testing 3.9.0rc1 and finally upgrade to 3.9.0 stable in a minor fix docker image release.
…-versions Upgrade all Python patch versions
Update Python 3.9 to 3.9.0 that it's released now
Wihtout `-L` we were creating an empty file and `bash` does not complain about it. We ended up with an image without `conda` installed at all.
…a-download Follow redirects when downloading Miniconda
After the image is built from the current commit, we spin up the container with the image just built and execute some commands to check the versions them.
It will download the image from Docker Hub and use its layers as cache.
I merged the branch, but I needed to cherry-pick all these commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport tests from #143 into
release/7.x
branch.