Prefix all of our variables with RTD_ to avoid issues
#128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PIP_VERSION and VIRTUALENV_VERSION are sensible variables that are read by pip and virtualenv respectively and we already have issues with them. So, to avoid this problem and future ones, we are prefixing all of our variables with `RTD_`.
|
This PR, once approved, has to be cherry-picked to |
ericholscher
approved these changes
Mar 11, 2020
|
Python tests will fail because no tests were ran. This PR fixes that #129 If the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PIP_VERSION and VIRTUALENV_VERSION are sensible variables that are read by pip and virtualenv respectively and we already have issues with them. So, to avoid this problem and future ones, we are prefixing all of our variables with
RTD_.