Moove ENV, LABEL to bottom #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having them close to the bottom allow us to share most of the layer from the Docker images even after a Python version was updated
Conda has been doing the package we updated the most in the last months. So, it may be good to have it the closest to the bottom as possible.
ericholscher
approved these changes
Mar 13, 2020
|
Not sure if this is still needed, or if it was adopted w/ the RTD prefix changes? |
|
The idea is still worth to explore: move the definition of the variable immediately before where it's used trying to share the as much as layer as we can. The PR needs to be adapted to the new naming with the |
…to humitos/move-env-labels-to-bottom
humitos
removed
the
PR: work in progress
|
I resolved the conflicts and it's ready to merge once the tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving all variables immediately before where they are needed. This allow us to share as much layer as we can when upgrading only one package.
I also moved conda to the bottom because it has been being the package the updated the most in the last months.
I also added more LABEL for the new pinned package versions. We are not using them though, so we may want to just remove them all.
Ref #124 (comment)