Remove LABEL version from Dockerfile and CONTRIBUTING guide
#118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since this is at the top of the Dockerfile this avoid us to share layers between different docker images even if the image share most of it.
|
@agjohnson is there a use for the LABEL? Im 👍 on this, unless there's a good reason to keep it? |
|
I remember that we wanted to query the image/container itself to know what Python versions where supported dynamically (other |
|
Nope, that's about all I remember as well. If it doesn't affect image builds, it seems okay to remove |
agjohnson
approved these changes
Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this is at the top of the Dockerfile this avoid us to share layers between different docker images even if the image share most of it.