Added Rust to the build image

[alex]

fixes #135

[alex]

If there's anything I can do to help move this forward, don't hesitate to ask!

[stsewd]

@alex sorry, we still need a decision from the core team at #135

[alex]

Understood.

[ericholscher]

This looks good to me, with one small comment.

[humitos]

Looks good to me! I added a small suggestion.

[ericholscher]

This will now build new images, we need to ship them to our builders before they are properly deployed. I will coordinate that on our side this week.

[alex]

Cool -- is there a good way for me to follow along with that?

…

On Tue, Sep 1, 2020 at 7:10 PM Eric Holscher ***@***.***> wrote: This will now build new images, we need to ship them to our builders before they are properly deployed. I will coordinate that on our side this week. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#136 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAAGBGAT4L3UOBIZB6CJYTSDV5NHANCNFSM4QBY7HIA> .

-- All that is necessary for evil to succeed is for good people to do nothing.

[humitos]

I cherry-picked the commits from this PR into release/7.x branch and tag it as 7.0.3. The image is now building at https://hub.docker.com/repository/registry-1.docker.io/readthedocs/build/builds/282d360d-269d-43b1-ae9b-e047aae9d06d

Next deploy, we need to tell our script to pull down the newer images and it should download a new image for readthedocs/build:7.0 containing Rust.

@alex what's your project slug/URL on Read the Docs? To use this image (called testing for now), you will need to use build.image with testing value in your config file (see https://docs.readthedocs.io/en/stable/config-file/v2.html#build-image) or we can force this image in your project, but I think it's better if you have the control.

[humitos]

I just pulled down the image created by Docker Hub with docker pull readthedocs/build:7.0 and run it locally:

▶ docker run --rm -it readthedocs/build:7.0 /bin/bash
docs@441297bd68da:/$ cargo --version
cargo 1.46.0 (149022b1d 2020-07-17)
docs@441297bd68da:/$

Seems it's working as expected 👍. I think we are ready to deploy it.

[alex]

Woooo! Thanks! בתאריך יום ה׳, 3 בספט׳ 2020, 8:55, מאת Manuel Kaufmann ‏< [email protected]>:

…

I just pulled down the image created by Docker Hub with docker pull readthedocs/build:7.0 and run it locally: ▶ docker run --rm -it readthedocs/build:7.0 /bin/bash ***@***.***:/$ cargo --version cargo 1.46.0 (149022b1d 2020-07-17) ***@***.***:/$ Seems it's working as expected 👍. I think we are ready to deploy it. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#136 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAAGBGEVVF6X27TJKZSIPTSD6G35ANCNFSM4QBY7HIA> .

[humitos]

Hi @alex! This is already deployed. Can you confirm that it's working as you expected when using testing as build: image in the config file? https://docs.readthedocs.io/en/stable/config-file/v2.html#build Thanks!

[alex]

Yup, we've been using this for a few weeks. Works great, thank you! בתאריך יום ב׳, 21 בספט׳ 2020, 11:20, מאת Manuel Kaufmann ‏< [email protected]>:

…

Hi @alex <https://github.com/alex>! This is already deployed. Can you confirm that it's working as you expected when using testing as build: image in the config file? https://docs.readthedocs.io/en/stable/config-file/v2.html#build Thanks! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#136 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAAGBBIUURMAQO2OIDDCU3SG5VLLANCNFSM4QBY7HIA> .

[humitos]

Excellent! Thanks!