Upgrade to Ubuntu 20.04 and Python 3.8 #7421
Conversation
- upgrade local development Docker image - upgrade Docker image in TravisCI - upgrade orjson to be able to install in newer Ubuntu version
redis has to be upgraded to avoid `async` keyword error
humitos
removed
the
PR: work in progress
|
I'm marking this as blocked for now until we do more test in production servers. I already opened a PR and I have all the data to build the image and run it in a VM. Once we passed that test we can merge this so we have local/prod with the same environment. See https://github.com/readthedocs/readthedocs-ops/pull/794 |
…humitos/ubuntu-20.04
|
Ay, a new conflict 😢 I've been seeing this perform fine in a Debian Buster container for over half a year and will continue to use it for 5.12.0. So really no worries from my POV. |
|
I updated this PR and all tests are passing. A good way to QA is to pull down the PR, and
Let me know @readthedocs/backend |
| # mercurial-scm.org/wiki/SupportedPythonVersions | ||
| # (Pinned to 4.4.2 since what we need for testing is still useful) | ||
| Mercurial==4.4.2 # pyup: ignore | ||
| Mercurial==5.5 |
There was a problem hiding this comment.
Is this still being used in our code, or only on builders?
There was a problem hiding this comment.
IIRC, this dependency was added because it was required on some tests. We may be able to remove them? I'll take a look at that later.
Python 3.6 is EOL and causes issues (lack of dataclasses breaks sphinx.ext.autodoc). I'm not sure what version is appropriate. ReadTheDocs themselves seem to have [defaulted to Python 3.8](readthedocs/readthedocs.org#7421), so that's what I went with.
Important changes
orjsonto be able to latest version (available for Py3.8)mercurialto its latest version which is compatible with Python 3.8Closes #8492
Closes #8151