Skip to content

Update to latest release of orjson #7332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

benjaoming
Copy link
Contributor

Researching if an upgrade is possible, re: #7313

Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good IMO, thanks! We should run inv docker.build from this PR, then inv docker.test and finally inv docker.up to import a project and trigger that build with search enabled. If everything works and the search returns valid results we can merge it!

@benjaoming
Copy link
Contributor Author

Thanks @humitos - I need to have a look at the inv tool, will get back with a result 👍

@humitos
Copy link
Member

humitos commented Jul 29, 2020

@benjaoming it's basically our tool to start the development instance. Just want to double check that it will work after merging. You can read more at https://docs.readthedocs.io/en/stable/development/standards.html

@stale
Copy link

stale bot commented Sep 12, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: stale Issue will be considered inactive soon label Sep 12, 2020
@humitos
Copy link
Member

humitos commented Sep 14, 2020

I think this PR won't be required anymore after #7421 gets merged.

@stale stale bot removed the Status: stale Issue will be considered inactive soon label Sep 14, 2020
@benjaoming benjaoming closed this Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants