Skip to content

Upgrade Python version of readthedocs to > 3.6 #8492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
astrojuanlu opened this issue Sep 15, 2021 · 3 comments · Fixed by #7421
Closed

Upgrade Python version of readthedocs to > 3.6 #8492

astrojuanlu opened this issue Sep 15, 2021 · 3 comments · Fixed by #7421

Comments

@astrojuanlu
Copy link
Contributor

Read the Docs requires Python 3.6, which is EOL this December:

https://www.python.org/dev/peps/pep-0494/

We should upgrade the application to run on a newer version.

@humitos
Copy link
Member

humitos commented Sep 15, 2021

We have an opened PR at #7421 that upgrades to Ubuntu 20.04 LTS and Python 3.8. That PR also requires using Ubuntu 20.04 LTS and Python 3.8 on the production servers (done at https://github.com/readthedocs/readthedocs-ops/pull/794)

Both PRs require an upgrade probably, but I wouldn't expect too many issues. The main work will be QA on the production environment and coordinated deployment.

@astrojuanlu
Copy link
Contributor Author

Thanks @humitos. It's not clear to me if #7421 depends on https://github.com/readthedocs/readthedocs-ops/pull/794, the other way around, or if they have to be deployed simultaneously.

@humitos
Copy link
Member

humitos commented Sep 15, 2021

Yes 😝

#7421 does not depend on https://github.com/readthedocs/readthedocs-ops/pull/794 to work locally. However, we cannot merge #7421 without merging https://github.com/readthedocs/readthedocs-ops/pull/794 as well because we will have Ubuntu 20.04 LTS and Py 3.8 locally but Ubuntu 18.04 LTS and Py 3.6 in production and that will produce issues.

Both PRs are required to be merged to do the deployment/release.

Does this clarify the situation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants