-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Removed __div__ impls from Cython #34718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I believe failure is unrelated. Looking into it but @jbrockmendel might have some ideas as well given his comment here ref #33858:
|
Nevermind had the wrong PR. Looks like it might trace back to #22699 |
hmm what is this needed for? |
These throw unused function warnings / errors in newer Cython versions during compilation
…Sent from my iPhone
On Jun 14, 2020, at 7:36 AM, Jeff Reback ***@***.***> wrote:
hmm what is this needed for?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
thanks |
@meeseeksdev backport to 1.0.x |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
Co-authored-by: William Ayd <[email protected]>
xref #34802 |
Alternate to #34711 which may close #34704