Skip to content

BUG: CI builds failing at compilation of _sas #34704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 of 3 tasks
martindurant opened this issue Jun 10, 2020 · 3 comments · Fixed by #34718
Closed
2 of 3 tasks

BUG: CI builds failing at compilation of _sas #34704

martindurant opened this issue Jun 10, 2020 · 3 comments · Fixed by #34718
Labels
Build Library building on various platforms CI Continuous Integration

Comments

@martindurant
Copy link
Contributor

martindurant commented Jun 10, 2020

  • I have checked that this issue has not already been reported.

  • I have confirmed this bug exists on the latest version of pandas.

  • (optional) I have confirmed this bug exists on the master branch of pandas.


Note: Please read this guide detailing how to provide the necessary information for us to reproduce your bug.

Code Sample, a copy-pastable example

See, for example, the build line https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=37068&view=logs&j=a3a13ea8-7cf0-5bdb-71bb-6ac8830ae35c&t=2296ffae-5e67-52bf-66a8-6160145a0f80&l=660
(and this appears to be failing other PRs too)

Problem description

CI builds are failing, see link above

Expected Output

@martindurant martindurant added Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Jun 10, 2020
@TomAugspurger TomAugspurger added Build Library building on various platforms CI Continuous Integration and removed Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Jun 10, 2020
@TomAugspurger
Copy link
Contributor

Maybe related to the Cython version? Locally, with Cython 29.20 I see

pandas/_libs/interval.c:8301:18: error: unused function '__pyx_pw_6pandas_5_libs_8interval_8Interval_25__div__' [-Werror,-Wunused-function]
static PyObject *__pyx_pw_6pandas_5_libs_8interval_8Interval_25__div__(PyObject *__pyx_v_self, PyObject *__pyx_v_y) {
                 ^
1 error generated.

With 29.19, I don't see that error. Let me try pining cython for that build.

TomAugspurger added a commit to TomAugspurger/pandas that referenced this issue Jun 11, 2020
Seeing if this resolves the build failure.

xref pandas-dev#34704
@TomAugspurger
Copy link
Contributor

CI should be passing again if people merge master in their PRs.

We'll leave this issue open to determine why this is generating unused functions with Cython 0.29.20.

@WillAyd
Copy link
Member

WillAyd commented Jun 11, 2020

Woud have to check Cython changelog but I guess would also just remove the __div__ method - isn't that a Py2 compat leftover?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms CI Continuous Integration
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants