Skip to content

CLN: address FIXME/TODO/XXX comments #33858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 29, 2020
Merged

CLN: address FIXME/TODO/XXX comments #33858

merged 3 commits into from
Apr 29, 2020

Conversation

jbrockmendel
Copy link
Member

  • changed XXX comments to TODO (much more grep-friendly, since we sometimes use XXX for a name attribute.
  • Removed some now-fixed FIXME/TODO comments
    • tests.arithmetic.test_datetime64, tests.arithmetic.test_period, test_conversion, tests.indexes.common, test_date_range, test_css, scalar.timedelta.test_arithmetic
  • Added some TODO(EA2D) comments
  • Removed some TODO(wesm): unused? comments

simonjayhawkins
simonjayhawkins reviewed Apr 29, 2020
View reviewed changes
pandas/tests/scalar/timedelta/test_arithmetic.py
@@ -652,7 +652,6 @@ def test_td_rfloordiv_numeric_series(self):
msg = "Invalid dtype"
with pytest.raises(TypeError, match=msg):
# Deprecated GH#19761, enforced GH#29797
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could probably remove this comment as well or does it adds value?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

either way i guess, the historical reference doesnt hurt

@simonjayhawkins simonjayhawkins added this to the 1.1 milestone Apr 29, 2020
@jreback jreback merged commit cf974b1 into pandas-dev:master Apr 29, 2020
@jreback
Copy link
Contributor

jreback commented Apr 29, 2020

thanks

@jbrockmendel jbrockmendel deleted the fixme branch April 29, 2020 19:14
jbrockmendel added a commit to jbrockmendel/pandas that referenced this pull request Apr 29, 2020
@jbrockmendel
CLN: address FIXME/TODO/XXX comments (pandas-dev#33858)
f898f4b
rhshadrach pushed a commit to rhshadrach/pandas that referenced this pull request May 10, 2020
@jbrockmendel @rhshadrach
CLN: address FIXME/TODO/XXX comments (pandas-dev#33858)
41d2a35
@WillAyd WillAyd mentioned this pull request Jun 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonjayhawkins simonjayhawkins simonjayhawkins left review comments

Assignees
No one assigned
Labels
Clean
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @jreback @simonjayhawkins