Skip to content

Make Cython in numpydev config Consistent #34712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

WillAyd
Copy link
Member

@WillAyd WillAyd commented Jun 11, 2020

Follow up to #34711 and just matching the other config files. Not sure generally if we should be specifying here and in higher level configs as may be ambiguous as to what Cython version gets installed, but going with the quick patch for now

@WillAyd
Copy link
Member Author

WillAyd commented Jun 11, 2020

I guess another alternate is to hard code only this to Cython 0.29.19 and leave the higher level config alone (essentially reverting #34711) @TomAugspurger

@TomAugspurger
Copy link
Contributor

Does the CI failure make sense to you?

____________________ TestDtype.test_check_dtype[Int64Dtype] ____________________

[gw1] linux -- Python 3.9.0 /home/travis/virtualenv/python3.9-dev/bin/python

self = <pandas.tests.extension.test_integer.TestDtype object at 0x7f7438777400>

data = <IntegerArray>

[   1,    2,    3,    4,    5,    6,    7,    8, <NA>,   10,   11,   12,   13,

   14,   15,   16,   17,...5,   86,   87,   88,   89,   90,   91,

   92,   93,   94,   95,   96,   97, <NA>,   99,  100]

Length: 100, dtype: Int64

    def test_check_dtype(self, data):

        dtype = data.dtype

    

        # check equivalency for using .dtypes

        df = pd.DataFrame(

            {"A": pd.Series(data, dtype=dtype), "B": data, "C": "foo", "D": 1}

        )

    

        # np.dtype('int64') == 'Int64' == 'int64'

        # so can't distinguish

        if dtype.name == "Int64":

            expected = pd.Series([True, True, False, True], index=list("ABCD"))

        else:

            expected = pd.Series([True, True, False, False], index=list("ABCD"))

    

        # FIXME: This should probably be *fixed* not ignored.

        # See libops.scalar_compare

        with warnings.catch_warnings():

            warnings.simplefilter("ignore", DeprecationWarning)

            result = df.dtypes == str(dtype)

    

>       self.assert_series_equal(result, expected)

pandas/tests/extension/base/dtype.py:84: 

_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

pandas/tests/extension/base/base.py:13: in assert_series_equal

    return tm.assert_series_equal(left, right, *args, **kwargs)

pandas/_libs/testing.pyx:68: in pandas._libs.testing.assert_almost_equal

    cpdef assert_almost_equal(a, b,

_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

>   raise_assert_detail(obj, msg, lobj, robj, index_values=index_values)

E   AssertionError: Series are different

E   

E   Series values are different (25.0 %)

E   [index]: [A, B, C, D]

E   [left]:  [True, True, False, False]

E   [right]: [True, True, False, True]

I think my preference is to just pin in the environment files and work to fixing the needs for the pins before 1.1 is released.

@WillAyd
Copy link
Member Author

WillAyd commented Jun 11, 2020

Surprising to see that at first glance. Just restarted let's see

@WillAyd
Copy link
Member Author

WillAyd commented Jun 11, 2020

Looks like that failure is showing up on a few other PRs

@WillAyd
Copy link
Member Author

WillAyd commented Jun 11, 2020

#34718 might be better than this for now. Let's see how that looks first

@WillAyd WillAyd closed this Jun 11, 2020
@WillAyd WillAyd deleted the unpin-cython branch April 12, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants