Skip to content

Removed __div__ impls from Cython #34718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 14, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ci/deps/azure-37-locale.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,7 @@ dependencies:
- python=3.7.*

# tools
# Cython pin for https://github.com/pandas-dev/pandas/issues/34704
- cython==0.29.19
- cython>=0.29.16
- pytest>=5.0.1
- pytest-xdist>=1.21
- pytest-asyncio
Expand Down
2 changes: 1 addition & 1 deletion environment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ dependencies:
- asv

# building
- cython=0.29.19
- cython>=0.29.16

# code checks
- black=19.10b0
Expand Down
5 changes: 0 additions & 5 deletions pandas/_libs/interval.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -424,11 +424,6 @@ cdef class Interval(IntervalMixin):
return Interval(y.left * self, y.right * self, closed=y.closed)
return NotImplemented

def __div__(self, y):
if isinstance(y, numbers.Number):
return Interval(self.left / y, self.right / y, closed=self.closed)
return NotImplemented

def __truediv__(self, y):
if isinstance(y, numbers.Number):
return Interval(self.left / y, self.right / y, closed=self.closed)
Expand Down
3 changes: 0 additions & 3 deletions pandas/_libs/tslibs/nattype.pyx
Original file line number Diff line number Diff line change
Expand Up @@ -221,9 +221,6 @@ cdef class _NaT(datetime):
def __neg__(self):
return NaT

def __div__(self, other):
return _nat_divide_op(self, other)

def __truediv__(self, other):
return _nat_divide_op(self, other)

Expand Down
2 changes: 1 addition & 1 deletion requirements-dev.txt
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ numpy>=1.15
python-dateutil>=2.7.3
pytz
asv
cython==0.29.19
cython>=0.29.16
black==19.10b0
cpplint
flake8<3.8.0
Expand Down