TST: stricter xfails, catch/suppress warnings #33882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove \n from docstring * fix issue 17038 * revert change * revert change * Remove TODO
mroeschke
approved these changes
Apr 30, 2020
on a travis build |
| result = op(array, nulls_fixture) | ||
| expected = self.elementwise_comparison(op, array, nulls_fixture) | ||
|
|
||
| if nulls_fixture is pd.NA and array.dtype != pd.IntervalDtype("int"): | ||
| pytest.xfail("broken for non-integer IntervalArray; see GH 31882") | ||
| mark = pytest.mark.xfail( |
There was a problem hiding this comment.
Perhaps a helpful function for this if we are going to do across the codebase? Jeff's idea - here
I'm happy to tackle some myself too :)
There was a problem hiding this comment.
Go for it. I think this is a strictly better pattern than pytest.xfail, since it will alert us if an xfail becomes fixed.
|
thanks |
rhshadrach
pushed a commit
to rhshadrach/pandas
that referenced
this pull request
May 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove box_df_fail which is no longer used