-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
TST: stricter xfails, catch/suppress warnings #33882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 26 commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
67ab32f
TST: fix xfailed arithmetic tests
jbrockmendel ae3837c
TST: strictify xfails
jbrockmendel 63cbaa9
strictify
jbrockmendel 5338c37
strictify xfail
jbrockmendel 5ba2112
stricter
jbrockmendel 13d93bf
fix xfail
jbrockmendel a8328bc
tighten
jbrockmendel 7ed3c67
take it all back
jbrockmendel 3f4fcbf
tighten tests
jbrockmendel 45b3cbb
CI: Skip permissions test when running as sudo (#33847)
TomAugspurger 1ce5589
troubleshoot
jbrockmendel 3fe8ab3
TST: stop skipping Categorical take tests (#33859)
jbrockmendel a2d025e
Fix typo (#33861)
taljaards 82e2463
REF/CLN: Parametrize _isna (#33835)
dsaxton 306044b
DOC: Code Standards Broken Link (#33865)
simonjayhawkins c6845da
TYP/CLN: remove #type: ignore from pandas\tests\base\test_conversion.…
simonjayhawkins f898f4b
CLN: address FIXME/TODO/XXX comments (#33858)
jbrockmendel ef09e64
DOC: Remove TODO from `test_openpyxl` (#33872)
charlesdong1991 3a56433
Merge branch 'master' of https://github.com/pandas-dev/pandas into xf…
jbrockmendel 7451dbc
Merge branch 'master' of https://github.com/pandas-dev/pandas into xf…
jbrockmendel 7bf479b
remove box_df_fail
jbrockmendel 6863882
TST: cactch/suppress warnings
jbrockmendel 32666d9
TST: catch/suppress warnings
jbrockmendel f27775c
TST: dynamic xfails
jbrockmendel 72096cf
Merge branch 'master' of https://github.com/pandas-dev/pandas into xf…
jbrockmendel 67e8731
troubleshoot CI
jbrockmendel 5ab07c5
Merge branch 'master' of https://github.com/pandas-dev/pandas into xf…
jbrockmendel 650aed3
un-silence
jbrockmendel 954994d
troubleshoot CI
jbrockmendel 33d2aab
troubleshoot CI
jbrockmendel 8641843
revert
jbrockmendel 930a421
troubleshoot interval
jbrockmendel be3a449
Merge branch 'master' of https://github.com/pandas-dev/pandas into xf…
jbrockmendel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps a helpful function for this if we are going to do across the codebase? Jeff's idea - here
I'm happy to tackle some myself too :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go for it. I think this is a strictly better pattern than
pytest.xfail
, since it will alert us if an xfail becomes fixed.