POC/TST: dynamic xfail #30521
Merged
POC/TST: dynamic xfail #30521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyoung
added
Enhancement
Testing
gfyoung
reviewed
Dec 28, 2019
|
Nice! wasn't aware of this - came in handy in #30544 |
|
Do we want to do this across the codebase? - I can create an issue if so |
sure, should create a convenience function to do this, put in _test_decorators |
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: we have a non-trivial number of places where we do
pytest.xfailwithin a test (as opposed to via decorator). This has the downside of always being non-strict, so incorrectly-xfailed tests will never show up as xpassing.This uses a workaround to dynamically add the pytest.mark.xfail marker within the test rather than raising pytest.xfail directly.
Thoughts?