DOC: Remove TODO from test_openpyxl
#33872
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, the CI failure is unrelated |
|
Thanks @charlesdong1991 |
jbrockmendel
pushed a commit
to jbrockmendel/pandas
that referenced
this pull request
Apr 29, 2020
* remove \n from docstring * fix issue 17038 * revert change * revert change * Remove TODO
rhshadrach
pushed a commit
to rhshadrach/pandas
that referenced
this pull request
May 10, 2020
* remove \n from docstring * fix issue 17038 * revert change * revert change * Remove TODO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #29862
Brought up by @jbrockmendel seems the
xfailhas been removed and version has been unpinned, just a tiny PR to remove thisTODOfrom tests. probably people who fixed it forgot to remove this.cc @jbrockmendel