CI: Fix version openpyxl #29862
CI: Fix version openpyxl #29862
Conversation
|
https://bitbucket.org/openpyxl/openpyxl/issues/1373/broken-writer-with-lxml-defusedxml Looks like there is a breaking change on openpyxl, so could limit it to |
|
Thanks for the fix @charlesdong1991 I don't think we want this. This will fix the error in the documentation, but |
|
oh, sorry, did not notice your comment when i was committing @datapythonista thanks for your review, i thought this was only a doc error since I only observed this doc error in my another failed PR, I will take a another look, or you mean you want an actual fix from |
The behavior that is failing in the docbuild should be made into a test (which will currently fail with new openpyxl) which we then need to fix on our end. |
|
that said, we could add a test and xfail it to avoid blocking for now (while keeping a fixed version of openpyxl). |
sounds good |
|
Thanks for both of your review @jreback and @jbrockmendel I made a new test and xfail if version of openpyxl if newer than 3.0.1, pls take a look to see if it is something we want now to avoid this blocker for other PRs. |
|
LGTM. Merging so we can get the CI back up |
|
Is there an issue for the openpyxl regression? (here in pandas or upstream) |
Potentially this: |
* remove \n from docstring * avoid upgrade * limit version * Add test and skip it for higher version * resort imports * change to xfail * fix typo * add ext * fix test * fix path * better check
* remove \n from docstring * avoid upgrade * limit version * Add test and skip it for higher version * resort imports * change to xfail * fix typo * add ext * fix test * fix path * better check
| @pytest.mark.xfail(openpyxl.__version__ > "3.0.1", reason="broken change in openpyxl") | ||
| def test_to_excel_with_openpyxl_engine(ext, tmpdir): | ||
| # GH 29854 | ||
| # TODO: Fix this once newer version of openpyxl fixes the bug |
There was a problem hiding this comment.
@charlesdong1991 any idea if this TODO can be addressed?
There was a problem hiding this comment.
this xfail should be removed!! new version of openpyxl has fixed the issue @jbrockmendel
There was a problem hiding this comment.
emm, seems have been removed on master.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff