CI: Fix npdev build #29860
Merged
CI: Fix npdev build #29860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jreback @TomAugspurger npdev build is green here |
| @@ -765,13 +765,15 @@ def test_concat_join_axes_deprecated(self, axis): | |||
| ) | |||
|
|
|||
| expected = pd.concat([one, two], axis=1, sort=False).reindex(index=two.index) | |||
| result = pd.concat([one, two], axis=1, sort=False, join_axes=[two.index]) | |||
| with tm.assert_produces_warning(FutureWarning): | |||
There was a problem hiding this comment.
Where are these warnings coming from?
There was a problem hiding this comment.
join_axes is deprecated
There was a problem hiding this comment.
And this failure wasn't caught earlier because the numpydev build is the only one that fails on warnings, and that was offline for a bit? If so, feel free to merge.
There was a problem hiding this comment.
That's my understanding, yes
There was a problem hiding this comment.
join_axes is already deprecated for a few months, so there's probably another reason ..
|
thanks! |
|
@jbrockmendel do you know if this are deliberate changes on numpy's side, or is this something to report upstream? |
|
not that im aware of |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.