-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Fail Azure CI for failing tests #23454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fail Azure CI for failing tests #23454
Conversation
Codecov Report
@@ Coverage Diff @@
## master #23454 +/- ##
=======================================
Coverage 92.25% 92.25%
=======================================
Files 161 161
Lines 51200 51200
=======================================
Hits 47232 47232
Misses 3968 3968
Continue to review full report at Codecov.
|
https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=2227&view=logs
Done - please see latest comment |
Hello @alimcmaster1! Thanks for updating the PR.
Comment last updated on November 04, 2018 at 13:46 Hours UTC |
This now looks like what we want: https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=2409&view=logs Build status goes to failed on everything but ( "Linux py36_locale_slow" - which doesn't seem to run my failing test in @TomAugspurger - I will now remove my dummy failing test. Any feedback/concerns with this PR? CC: Azure Folks @vtbassmatt, @davidstaheli - for any comments - as this touches a few files that #23111 does |
Sorry for the delay. This LGTM. Will merge on green. |
that's due to the |
Ahh merge conflict :) I'll fix that up quick. |
Np at all @TomAugspurger my fault - I only just pushed the change to remove my failing test. And aah thanks for the info re the |
…-fail-build-on-test-fail
Merged master and canceled the previous commit's build. |
Thanks for working on this @alimcmaster1! |
@@ -54,3 +54,28 @@ jobs: | |||
inputs: | |||
testResultsFiles: 'test-data-*.xml' | |||
testRunTitle: 'Linux' | |||
- powershell: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alimcmaster1 any idea if there is a way to do this in bash? xref #30393 the two remaining places where we do this are among the last windows-special-casing left
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure let me take a look - unless we are moving the CI to github actions soon? #29715 @datapythonista in which case I might wait for that to happen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not so soon - things will move gradually and smooothly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will take time, and besides what Jeff said, it's not yet clear that GitHub will give us all the workers we need, so may be we need to keep Azure in the long term.
git diff upstream/master -u -- "*.py" | flake8 --diff
This should hopefully return a failed status on Azure