Skip to content

WIP: All the CI in GitHub actions (DO NOT MERGE) #29715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 59 commits into from
Closed

WIP: All the CI in GitHub actions (DO NOT MERGE) #29715

wants to merge 59 commits into from

Conversation

datapythonista
Copy link
Member

Many things are incomplete or broken here, but opening this so people can see the progress.

This needs to be discussed, and if we move forward splitted in many PRs, before it can be merged.

This adds all our current builds to GitHub actions, with two new features:

  • Creating an artifact for the built web and docs
  • A Finalize job is triggered when all the others are finished, that should summarize the errors in a GitHub comment (WIP)

Some things that are broken:

  • The builds with locale different than English
  • The grep that checks if there are ipython errors in the sphinx logs
  • The builds other than Linux (because the matrix tries to create the containers for MySQL and PostgreSQL for all builds now)
  • The Finalize job is WIP, and not sure if even triggered

I'll probably work on #29685 before adding any test build to actions. I think we can do much better in terms of simplicity and coverage with the creation of the matrix (which builds we run, and what's tested in each).

@datapythonista datapythonista added CI Continuous Integration Needs Discussion Requires discussion from core team before further action labels Nov 19, 2019
@jbrockmendel
Copy link
Member

@datapythonista anything i/others can do to help with this?

@datapythonista
Copy link
Member Author

@datapythonista anything i/others can do to help with this?

So far I'm mainly experimenting, to see challenges and what can be done. There are several builds that are working now, but I'd probably wait for now, before moving anything. I'd probably start by the web+docs build, and the ones in travis, and those are the ones that are failing (besides the windows ones).

What's your idea? If you'd like to see things in GitHub actions soon, we can discuss and see how can split this already. Is there anything that you think we should prioritize?

@jbrockmendel
Copy link
Member

I don't have any ideas, no, just was going through PRs and seeing where I might be useful

@datapythonista
Copy link
Member Author

Closing this, was just for testing. Will propose new builds to GitHub actions incrementally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Needs Discussion Requires discussion from core team before further action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants