-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
CI: GitHub action for checks (linting, docstrings...) #29546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Is this supposed to take the place of something currently in travis/azure? or totally new? |
This is replicating part of the I guess in some time we'll want to replace both azure pipelines and travis with GitHub actions, but it's early to start discussing about it. |
…een pushed to the fork
@pandas-dev/pandas-core here you can see how GitHub actions will look like: The main advantage over azure-pipelines is that clicking on If we're happy to move forward, we can merge this, and leave the |
.github/workflows/ci.yml
Outdated
run: | | ||
export PATH=$HOME/miniconda3/bin:$PATH | ||
source activate pandas-dev | ||
ci/code_checks.sh docstrings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this right? do we have a separate code checks for typing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. I guess I copy-pasted incorrectly while transforming the yaml.
Fixed. I also remove the activate action here, which is not needed anymore now that actions is already active, and new actions are executed in PRs.
lgtm. can you rebase |
@jreback rebased and all green |
thanks |
https://github.com/pandas-dev/pandas/runs/306852441#step:3:36 @datapythonista @jreback : I think this might have been merged too soon. What's going on here? |
ahh it’s not actually failing thanks for the catch @gfyoung @datapythonista can u follow up |
Wow, it's really amazing that we can link to a specific line in the log. :) I don't think we had this before, right? Thanks for the heads up @gfyoung. I don't quite understand what's going on, but let me have a look. |
Travis CI has had this functionality for quite some time. Why Azure does not escapes me 🙂. |
Just to deliver some feedback we've just developed an extensive GHA configuration in Apache Arrow and we are pleased so far (see https://github.com/apache/arrow/tree/master/.github/workflows), if you have any questions @kszucs would be a good person to talk to, there's probably plenty we can learn from our respective experiences |
@datapythonista we keep our linux builds in docker containers, which is CI agnostic, makes local reproducibility possible and speeds up the builds in case of many dependencies. I'll try to take a closer look on your current CI scripts and your PR in the upcoming days. |
xref #29472