Skip to content

CI: GitHub action for checks (linting, docstrings...) #29546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 38 commits into from
Nov 18, 2019
Merged

CI: GitHub action for checks (linting, docstrings...) #29546

merged 38 commits into from
Nov 18, 2019

Conversation

datapythonista
Copy link
Member

@datapythonista datapythonista commented Nov 11, 2019

xref #29472

@jbrockmendel
Copy link
Member

Is this supposed to take the place of something currently in travis/azure? or totally new?

@datapythonista
Copy link
Member Author

This is replicating part of the Web_and_Docs build in azure. I expected this PR to create a new check, next to the travis and azure builds, to see how it looks like. But seems like it needs to be committed to run (or I am missing something).

I guess in some time we'll want to replace both azure pipelines and travis with GitHub actions, but it's early to start discussing about it.

@datapythonista datapythonista changed the title WIP/CI: Draft of GitHub action for web and docs CI: GitHub action for web and docs, without publishing it Nov 16, 2019
@datapythonista datapythonista changed the title CI: GitHub action for web and docs, without publishing it CI: GitHub action for checks (linting, docstrings...) Nov 17, 2019
@datapythonista datapythonista added the CI Continuous Integration label Nov 17, 2019
@datapythonista
Copy link
Member Author

@pandas-dev/pandas-core here you can see how GitHub actions will look like:

The main advantage over azure-pipelines is that clicking on Details takes you directly to the list of steps/errors. I also find the yaml syntax of actions a bit clearer than pipelines.

If we're happy to move forward, we can merge this, and leave the Checks build for a while in both systems, until we're confident with actions, and then we keep moving other things.

run: |
export PATH=$HOME/miniconda3/bin:$PATH
source activate pandas-dev
ci/code_checks.sh docstrings
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this right? do we have a separate code checks for typing

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I guess I copy-pasted incorrectly while transforming the yaml.

Fixed. I also remove the activate action here, which is not needed anymore now that actions is already active, and new actions are executed in PRs.

@jreback
Copy link
Contributor

jreback commented Nov 17, 2019

lgtm. can you rebase

@datapythonista
Copy link
Member Author

@jreback rebased and all green

@jreback jreback added this to the 1.0 milestone Nov 18, 2019
@jreback jreback merged commit 4bdce98 into pandas-dev:master Nov 18, 2019
@jreback
Copy link
Contributor

jreback commented Nov 18, 2019

thanks

@gfyoung
Copy link
Member

gfyoung commented Nov 18, 2019

https://github.com/pandas-dev/pandas/runs/306852441#step:3:36

@datapythonista @jreback : I think this might have been merged too soon. What's going on here?

@jreback
Copy link
Contributor

jreback commented Nov 18, 2019

ahh it’s not actually failing

thanks for the catch @gfyoung

@datapythonista can u follow up

@datapythonista
Copy link
Member Author

Wow, it's really amazing that we can link to a specific line in the log. :) I don't think we had this before, right?

Thanks for the heads up @gfyoung. I don't quite understand what's going on, but let me have a look.

@gfyoung
Copy link
Member

gfyoung commented Nov 18, 2019

Wow, it's really amazing that we can link to a specific line in the log.

Travis CI has had this functionality for quite some time. Why Azure does not escapes me 🙂.

@wesm
Copy link
Member

wesm commented Nov 19, 2019

Just to deliver some feedback we've just developed an extensive GHA configuration in Apache Arrow and we are pleased so far (see https://github.com/apache/arrow/tree/master/.github/workflows), if you have any questions @kszucs would be a good person to talk to, there's probably plenty we can learn from our respective experiences

@datapythonista
Copy link
Member Author

Thanks for the info @wesm. Looks quite interesting, need to check in more detail.

I just opened a PR for a draft of our CI in actions: #29715

@kszucs happy to discuss and share experiences.

@kszucs
Copy link

kszucs commented Nov 20, 2019

@datapythonista we keep our linux builds in docker containers, which is CI agnostic, makes local reproducibility possible and speeds up the builds in case of many dependencies. I'll try to take a closer look on your current CI scripts and your PR in the upcoming days.

proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants