Skip to content

CI: GitHub action for checks (linting, docstrings...) #29546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 38 commits into from
Nov 18, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
814f5e0
WIP/CI: Draft of GitHub action for web and docs
datapythonista Nov 11, 2019
7ba98c6
Removing failing apt install, and adding artifacts
datapythonista Nov 11, 2019
60facf6
Setting environemnt variables
datapythonista Nov 11, 2019
601d13e
Trying to fix event trigger and env variables
datapythonista Nov 12, 2019
7ccb366
Fixing PATH env variable manually
datapythonista Nov 12, 2019
4dc4e4e
Fixing typo (steps keyword previously removed by mistake)
datapythonista Nov 12, 2019
ac1ea2b
Adding checks job, and testing env variables
datapythonista Nov 12, 2019
3e1ff9a
Testing how env variables work
datapythonista Nov 12, 2019
d2e3347
Testing how env variables work
datapythonista Nov 12, 2019
fcd7282
More env tests, and adding path
datapythonista Nov 12, 2019
6f7a8e2
More env tests
datapythonista Nov 12, 2019
253cdde
Removing env tests
datapythonista Nov 12, 2019
5f5e0bd
Adding jobs to test output and requests post
datapythonista Nov 12, 2019
f84e198
Adding missing runs-on properties
datapythonista Nov 12, 2019
5788c14
Fixing errors in showing output and requesting url
datapythonista Nov 12, 2019
9f8264b
Merge remote-tracking branch 'upstream/master' into github_actions
Nov 13, 2019
b704bde
Removing tests
datapythonista Nov 13, 2019
8ab4074
Adding debug info to see why detected version is 0.15
datapythonista Nov 14, 2019
2a76a85
Adding lots of traces to identify where the version is coming from
datapythonista Nov 14, 2019
0703635
Reverting version traces
datapythonista Nov 14, 2019
c06e6b6
Showing more git info
datapythonista Nov 14, 2019
55664e8
Trying to fetch tags after the checkout
datapythonista Nov 14, 2019
62b21ca
Removing most of versions/tags info, should work now that tags have b…
datapythonista Nov 14, 2019
4922b3a
Removing all debug info
datapythonista Nov 14, 2019
3475e02
Merge remote-tracking branch 'upstream/master' into github_actions
datapythonista Nov 14, 2019
47aa9a5
Merge remote-tracking branch 'upstream/master' into github_actions
datapythonista Nov 14, 2019
0348a24
Adding debug information on exit codes
datapythonista Nov 14, 2019
4b723ed
Temporary removing failure on ipython code blocks
datapythonista Nov 15, 2019
24ddef6
Adding missing params to upload artifact
datapythonista Nov 15, 2019
51a454a
Merge remote-tracking branch 'upstream/master' into github_actions
datapythonista Nov 16, 2019
f4ad34b
Revert "Temporary removing failure on ipython code blocks"
datapythonista Nov 16, 2019
975dc7f
Merge remote-tracking branch 'upstream/master' into github_actions
datapythonista Nov 16, 2019
a6c9242
displaying exit status of sphinx and ipython validation separately
datapythonista Nov 16, 2019
0ae8d54
Renaming action name for now
datapythonista Nov 16, 2019
d0e9319
Renaming, and adding traces to find out the cause of the failure
datapythonista Nov 16, 2019
a1cd094
Removing docs build, adding to actions checks build for now
datapythonista Nov 17, 2019
980e824
Fixing typo in typing step, and removing activate action
datapythonista Nov 17, 2019
4aebdf2
Merge from master
datapythonista Nov 17, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 0 additions & 21 deletions .github/workflows/activate.yml

This file was deleted.

103 changes: 103 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,103 @@
name: CI

on:
push:
branches: master
pull_request:
branches: master

env:
ENV_FILE: environment.yml
# TODO: remove export PATH=... in each step once this works
# PATH: $HOME/miniconda3/bin:$PATH

jobs:
checks:
name: Checks
runs-on: ubuntu-latest
steps:

- name: Checkout
uses: actions/checkout@v1

- name: Looking for unwanted patterns
run: ci/code_checks.sh patterns
if: true

- name: Setup environment and build pandas
run: |
export PATH=$HOME/miniconda3/bin:$PATH
ci/setup_env.sh
if: true

- name: Linting
run: |
export PATH=$HOME/miniconda3/bin:$PATH
source activate pandas-dev
ci/code_checks.sh lint
if: true

- name: Dependencies consistency
run: |
export PATH=$HOME/miniconda3/bin:$PATH
source activate pandas-dev
ci/code_checks.sh dependencies
if: true

- name: Checks on imported code
run: |
export PATH=$HOME/miniconda3/bin:$PATH
source activate pandas-dev
ci/code_checks.sh code
if: true

- name: Running doctests
run: |
export PATH=$HOME/miniconda3/bin:$PATH
source activate pandas-dev
ci/code_checks.sh doctests
if: true

- name: Docstring validation
run: |
export PATH=$HOME/miniconda3/bin:$PATH
source activate pandas-dev
ci/code_checks.sh docstrings
if: true

- name: Typing validation
run: |
export PATH=$HOME/miniconda3/bin:$PATH
source activate pandas-dev
ci/code_checks.sh typing
if: true

- name: Testing docstring validation script
run: |
export PATH=$HOME/miniconda3/bin:$PATH
source activate pandas-dev
pytest --capture=no --strict scripts
if: true

- name: Running benchmarks
run: |
export PATH=$HOME/miniconda3/bin:$PATH
source activate pandas-dev
cd asv_bench
asv check -E existing
git remote add upstream https://github.com/pandas-dev/pandas.git
git fetch upstream
if git diff upstream/master --name-only | grep -q "^asv_bench/"; then
asv machine --yes
ASV_OUTPUT="$(asv dev)"
if [[ $(echo "$ASV_OUTPUT" | grep "failed") ]]; then
echo "##vso[task.logissue type=error]Benchmarks run with errors"
echo "$ASV_OUTPUT"
exit 1
else
echo "Benchmarks run without errors"
fi
else
echo "Benchmarks did not run, no changes detected"
fi
if: true