Skip to content

CI: transition powershell-> bash #30393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 23, 2019
Merged

Conversation

jbrockmendel
Copy link
Member

xref #26344

If this works, i think the remaining places to bashify are

  • identical powerhsell commands in windows.yml and posix.yml to check for test failures
  • conda.recipe/bld.bat (do we need this directory at all?)
  • test.bat, test_fast.bat (do we need the bash versions of these?)

@gfyoung gfyoung added Build Library building on various platforms CI Continuous Integration labels Dec 22, 2019
@WillAyd WillAyd added this to the 1.0 milestone Dec 23, 2019
@WillAyd WillAyd merged commit f0cb545 into pandas-dev:master Dec 23, 2019
@WillAyd
Copy link
Member

WillAyd commented Dec 23, 2019

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the ci-cln2 branch December 23, 2019 15:48
@jbrockmendel
Copy link
Member Author

@jreback any idea if we need conda.recipe or test/test_fast files mentioned in the OP? (or binstar.yml, that looks you-specific)

@jreback
Copy link
Contributor

jreback commented Dec 23, 2019

binstar is really old can remove

the test_fast are local scripts
need a canonical way to run all tests
how do u usually do it?

@jbrockmendel
Copy link
Member Author

how do u usually do it?

In my .bash_aliases file i have

gitd () {
	BRANCH=$1
	rm -rf ../$BRANCH
	git worktree prune
	git branch -D $BRANCH
}

pbranch () {
	BRANCH=$1
	git branch $BRANCH
	git worktree add ../$BRANCH $BRANCH
	cd ..
	cd $BRANCH
	python3 setup.py build_ext --inplace
}

alias ptest="python3 -m pytest pandas/tests --skip-slow --skip-db"
alias pflake="git diff --name-only | grep '\.py$' | xargs flake8"
alias psort="git diff --name-only | grep '\.py$' | xargs isort"
alias pblack="git diff --name-only | grep '\.py$' | xargs black"
alias pbuild="python3 setup.py build_ext --inplace"
alias ppull="git pull upstream master"

@jbrockmendel
Copy link
Member Author

need a canonical way to run all tests

if we want to support this robustly, we might want to consider going back to tox

@WillAyd
Copy link
Member

WillAyd commented Dec 23, 2019

@jbrockmendel the one disadvantage to your commands versus pytest would be the lack of parallel execution (i.e. -n 8 flag). Indifferent on getting rid of the file but if we do probably worth specifying the parallel execution ability as it can save significant time when running tests

@jreback
Copy link
Contributor

jreback commented Dec 24, 2019

so would be nice to push some of these commands to the makefile:)

also not averse to having. single canonical test_fast.sh (which we basically have now)

AlexKirko pushed a commit to AlexKirko/pandas that referenced this pull request Dec 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants