Skip to content

Fix miniconda path issue #26962 #27787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Aug 7, 2019

Conversation

bhavaniravi
Copy link
Contributor

@bhavaniravi bhavaniravi commented Aug 6, 2019

@gfyoung gfyoung added CI Continuous Integration Clean labels Aug 6, 2019
Copy link
Member

@gfyoung gfyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@datapythonista : If you have anything to add here

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really nice clean up, thanks for taking care of this @bhavaniravi

just couple of minor things, but looks great

@datapythonista datapythonista merged commit 820e09e into pandas-dev:master Aug 7, 2019
@datapythonista
Copy link
Member

Thanks @bhavaniravi, really great to have this fixed, much cleaner now

@bhavaniravi
Copy link
Contributor Author

Thank you @datapythonista I learned a lot in the process. Looking to contribute more on the devops side of things

quintusdias pushed a commit to quintusdias/pandas_dev that referenced this pull request Aug 16, 2019
- powershell: Write-Host "##vso[task.prependpath]$env:CONDA\Scripts"
- powershell: |
Write-Host "##vso[task.prependpath]$env:CONDA\Scripts"
Write-Host "##vso[task.prependpath]$HOME/miniconda3/bin"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bhavaniravi any idea if there is a way to do this without powershell? now that windows supports bash, im trying to see if we can get rid of windows-specific stuff

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In bash this is a simple echo I think.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats what I thought too, see #30393 where I tried that in the first commit and reverted it when that failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Clean
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: Fix Azure Pipelines problem with PATH
4 participants