-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Fix miniconda path issue #26962 #27787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix miniconda path issue #26962 #27787
Conversation
…to fix/miniconda_path
…to fix/miniconda_path
…to fix/miniconda_path
…to fix/miniconda_path
…to fix/miniconda_path
…to fix/miniconda_path
…to fix/miniconda_path
…to fix/miniconda_path
…to fix/miniconda_path
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
@datapythonista : If you have anything to add here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
really nice clean up, thanks for taking care of this @bhavaniravi
just couple of minor things, but looks great
Thanks @bhavaniravi, really great to have this fixed, much cleaner now |
Thank you @datapythonista I learned a lot in the process. Looking to contribute more on the devops side of things |
- powershell: Write-Host "##vso[task.prependpath]$env:CONDA\Scripts" | ||
- powershell: | | ||
Write-Host "##vso[task.prependpath]$env:CONDA\Scripts" | ||
Write-Host "##vso[task.prependpath]$HOME/miniconda3/bin" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bhavaniravi any idea if there is a way to do this without powershell? now that windows supports bash, im trying to see if we can get rid of windows-specific stuff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In bash this is a simple echo I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thats what I thought too, see #30393 where I tried that in the first commit and reverted it when that failed
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff