CI: Remove powershell scripts (Azure) #30431
Conversation
pandas/tests/arrays/test_array.py
Outdated
| @@ -343,7 +343,7 @@ def test_searchsorted(self, string_dtype): | |||
|
|
|||
| result = arr.searchsorted("a", side="left") | |||
| assert is_scalar(result) | |||
| assert result == 0 | |||
| assert result == 1 | |||
There was a problem hiding this comment.
Checking that test failures fail CI
| - bash: | | ||
| conda env create -q --file ci\\deps\\azure-windows-$(CONDA_PY).yaml | ||
| displayName: 'Create anaconda environment' | ||
|
|
There was a problem hiding this comment.
Making newline between each step consistent with posix.yml
|
Nice! Thanks for taking a look at this. LGTM pending green. |
| @@ -69,20 +69,13 @@ jobs: | |||
| displayName: 'Build versions' | |||
|
|
|||
| - task: PublishTestResults@2 | |||
| condition: succeededOrFailed() | |||
There was a problem hiding this comment.
Is there a particular reason to specify this instead of keeping as always?
There was a problem hiding this comment.
My understand was that suceeded() is the default condition on Azure as per docs:
By default, steps, jobs, and stages run if all previous steps/jobs have succeeded. It's as if you specified "condition: succeeded()" (see Job status functions).
And I thought we want to publish test results regardless of whether failures are produced? Or am I missing something?
There was a problem hiding this comment.
My mistake. I guess ultimately my question is this versus always if it matters
There was a problem hiding this comment.
Thanks for taking a look! Apparently always() will run even if the pipeline is cancelled -> that's the difference
| - bash: | | ||
| source activate pandas-dev | ||
| conda list | ||
| ci\\incremental\\build.cmd | ||
| displayName: 'Build' | ||
|
|
There was a problem hiding this comment.
#30393 should have gotten rid of the build.cmd on L37. this isnt going to re-introduce it by accident?
There was a problem hiding this comment.
Apologies just merged master
|
is the net effect of this that azure will run all steps but fail the build if anyone of them fails? |
Goal behind this is #26344 to get rid of the powershell scripts. (Azure step conditions are unchanged - apart from Publish test result - which will run regardless of the outcome of previous) |
|
cool, thanks @alimcmaster1 |
Ref @jbrockmendel comment here #23454 (comment)
CI: fails as expected example here