CI: Moving CI dependencies to "ci/deps" #23526
Conversation
datapythonista
added
CI
There was a problem hiding this comment.
+1 I think this greatly improves navigating in this directory.
I wanted to suggest one subdir per CI provider (so eg putting all env yaml files in /ci/azure, /ci/circle/ etc), but I see there are already yaml files for config in ci/azure, so that will probably make is more confusing to mix env and config yaml files. And since we use consistent suffix, putting them all in one directory is fine as well (and the positive side is that they are all in one place).
Codecov Report
@@ Coverage Diff @@
## master #23526 +/- ##
==========================================
- Coverage 92.25% 92.25% -0.01%
==========================================
Files 161 161
Lines 51169 51186 +17
==========================================
+ Hits 47207 47222 +15
- Misses 3962 3964 +2
Continue to review full report at Codecov.
|
|
looks good. need a clean run though, not sure what is failing. |
|
Need to update I wonder if that script can be removed... but OK with just changing the path. |
|
I didn't see that one, thanks for pointing out, I couldn't find the error. Changed now. |
|
I think all green @datapythonista are the failures at https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=2559&view=results what we have on master right now? |
|
I haven't seen those errors before. But I think this is the last build of master, and they are there too: https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=2565&view=results |
|
k. feel free to merge this then. I'll open an issue and investigate.
…On Tue, Nov 6, 2018 at 1:44 PM Marc Garcia ***@***.***> wrote:
I haven't seen those errors before. But I think this is the last build of
master, and they are there too:
https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=2565&view=results
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#23526 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABQHIvxVPb-o_iWAm_dlUMa0stCSllCWks5usealgaJpZM4YP6WN>
.
|
|
I think that #23454 is fixing this.
On Tue, Nov 6, 2018 at 1:45 PM Tom Augspurger <[email protected]>
wrote:
… k. feel free to merge this then. I'll open an issue and investigate.
On Tue, Nov 6, 2018 at 1:44 PM Marc Garcia ***@***.***>
wrote:
> I haven't seen those errors before. But I think this is the last build of
> master, and they are there too:
> https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=2565&view=results
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#23526 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ABQHIvxVPb-o_iWAm_dlUMa0stCSllCWks5usealgaJpZM4YP6WN>
> .
>
|
|
Yes they are on master - this PR here fixes them and also address the issue that build status does not go red when tests fail - #23454 |
git diff upstream/master -u -- "*.py" | flake8 --diff@jreback you were +0 on this, do you want to take a look? Also @TomAugspurger and @jbrockmendel